Organize E2E tests into flat specs directory (FRO-509)#43
Open
JGJP wants to merge 2 commits into
Open
Conversation
Move test files from nested tests/<category>/ directories into a flat e2e/specs/ directory with category prefixes. Update playwright config testMatch patterns accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request flattens the Playwright E2E test layout by consolidating suite-specific subdirectories into a single e2e/specs/ directory using suite-prefixed spec filenames, and updates Playwright project selection to match the new convention.
Changes:
- Updated spec file import paths to align with the new
e2e/specs/location. - Renamed/standardized spec naming to
<suite>-*.spec.tsand adjusted PlaywrighttestMatchpatterns accordingly. - Updated an inline comment in the EOA spec to reference the new Google RPC spec filename.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| e2e/specs/smoke-dashboard-loads.spec.ts | Updates page-object import path for the flattened specs directory. |
| e2e/specs/line-rpc-methods.spec.ts | Updates lib/page-object imports to the new relative paths under e2e/specs/. |
| e2e/specs/google-rpc-methods.spec.ts | Updates lib/page-object imports to the new relative paths under e2e/specs/. |
| e2e/specs/eoa-rpc-methods.spec.ts | Updates fixture/lib/page-object imports and adjusts a comment to the new spec filename. |
| e2e/specs/eoa-required-onboarding.spec.ts | Updates fixture/lib/page-object imports to the new relative paths under e2e/specs/. |
| e2e/playwright.config.ts | Updates project testMatch regexes to target specs/<suite>-*.spec.ts files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
.claude/rules/e2e.md:12
- This instruction says to add new RPC method tests only to
specs/google-rpc-methods.spec.ts, but CI runs the LINE suite by default. If the intent is to keep LINE and Google RPC suites in parity, please update the guidance to ensure new tests are added to the suite(s) that run in CI (or to both suites/shared helpers).
When adding a new RPC method test, add it to `specs/google-rpc-methods.spec.ts`.
e2e/specs/eoa-rpc-methods.spec.ts:18
- The comment references
google-rpc-methods.spec.tswithout thespecs/prefix, while other docs usespecs/<file>. Consider updating this to the full relative path (specs/google-rpc-methods.spec.ts) for consistency and to avoid ambiguity when grepping docs/comments.
Comment on lines
5
to
+9
| RPC method tests run with **Google OAuth as the primary authentication method**. MetaMask EOA tests verify connectivity only. | ||
|
|
||
| | Suite | Auth | Scope | File | | ||
| |-------|------|-------|------| | ||
| | Google OAuth | Google | All RPC method tests | `tests/google/rpc-methods.spec.ts` | | ||
| | MetaMask EOA | MetaMask | Connection + personal_sign | `tests/eoa/rpc-methods.spec.ts` | | ||
| | Google OAuth | Google | All RPC method tests | `specs/google-rpc-methods.spec.ts` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flatten E2E test directory structure from nested
tests/<category>/directories into a singlee2e/specs/directory with category prefixes (e.g.google-rpc-methods.spec.ts). Update playwright configtestMatchpatterns to match the new naming convention.Resolves FRO-509