Add shared claude config to app-sdk#42
Open
JGJP wants to merge 86 commits into
Open
Conversation
Document the three-tier config convention and add a minimal .claude directory skeleton with example *.team.* files. Made-with: Cursor
- Add group tier between team and project tiers - Document available groups: strium, startale, sdk - Add instructions for switching group branches in submodule - Update .gitignore snippet to include *.group.* and *.local.* patterns
## Rules (.claude/rules/design-and-ux/)
Four rule files providing passive context for UI development:
- **ux.team.md** — UX patterns, component conventions, layout rules
- Use existing components first, extract reusables
- Typography scale, page layout (mx-auto max-w-lg)
- Dark/light mode, empty/loading states, forms, feedback
- **a11y.team.md** — Accessibility standards (WCAG)
- Semantic HTML, ARIA patterns, keyboard navigation
- Focus management, color contrast (4.5:1 AA)
- Screen reader support, form accessibility
- **motion.team.md** — Animation and transitions
- Page transitions (fade), dialog transitions (scale+fade, slide)
- Easing (ease-out entrances, ease-in exits)
- Performance (transform/opacity only), reduced-motion fallbacks
- **interaction.team.md** — Interaction design patterns
- Five states: default → hover → focus-visible → active → disabled
- 44×44px touch targets, dialog close affordances
- Optimistic UI, disabled state explanations
## Commands (.claude/commands/design-and-ux/)
- **review-ux.team.md** — Full UX review across all four rule groups
- Pre-check for component duplication
- Accessibility, motion, interaction, UX pattern checks
- Structured report with severity levels
- **review-motion.team.md** — Motion-only subset of /review-ux
- For focused animation/transition work
## Hooks (.claude/hooks/design-and-ux/)
- **pre-commit-ux-prompt.team.md** — Prompts engineer to run /review-ux
when *.tsx or *.css files are staged (non-blocking)
## Skills (.claude/skills/design-and-ux/)
- **design-system.team.md** — Design system context on demand
- Surfaces tokens (color, typography, spacing, shadows)
- Component inventory with usage examples
- Icon system patterns and a11y rules
- Motion system (timing, patterns, reduced-motion)
- Interaction patterns (states, touch targets, focus, forms)
- Anti-patterns registry (AI fingerprints to avoid)
- Based on: Anthropic frontend-design, Impeccable, Vercel
web-interface-guidelines, AccessLint
## README updates
- Documented slash commands (/review-ux, /review-motion)
- Documented hooks (pre-commit-ux-prompt)
- Added rules reference table
- Added skills section
- Updated folder structure to show design-and-ux/ organization
Explains why we use Impeccable (addresses AI slop problem), lists all 20 slash commands, and describes how skills connect to each other and to project context via .impeccable.md.
- Replace manual installation with npx skills add - Move skills to .agents/ with symlinks for multi-tool support - Add enhanced /critique (Nielsen heuristics, personas, cognitive load) - Add enhanced /audit (P0-P3 severity ratings) - Add skills-lock.json for version tracking - Supports: Claude Code, Augment, Continue, Windsurf, and more
- Remove .agents, .augment, .continue, .windsurf directories (added by Impeccable skills CLI for multi-editor support) - Replace broken symlinks in .claude/skills with actual skill files - Remove skills-lock.json - Update README: switch from submodule to git subtree setup, add symlink instructions, document merge direction rules, add subtree push branch naming convention
Change subtree PR branch naming from subtree/<project>/... to from/<project>/... for clarity. Add contributing.team.md rule so Claude suggests the correct branch naming convention.
Move four-tier system and repo structure under "How it works". Move branch/merge rules under "Pushing changes back". Add table of contents. Design and UX is now a subsection of What's included.
Update contributing.team.md with clear criteria for deciding whether content belongs in team or group files. Update README with PR target branch guidance table. Ensures Claude and contributors know not to mix tiers.
Update Step 1 with a table showing which branch to use for each project type. Update cc-pull alias and pull docs to reference group branch instead of main. Add project-tier guidance to contributing rule.
Drop --squash to preserve full commit history in consumer projects and improve reliability of subtree push/pull round-trips.
…-rules Add code review expectations to team rules
Repo root now IS the .claude content. Consumer projects use prefix .claude so contents land directly in .claude/ with no symlink needed. Update README, .gitignore, and setup docs.
master to group branches When master is updated, GitHub Actions merges it into each group/* branch (strium, startale, sdk). Uses fail-fast: false so one confli does not block other group syncs.
Added CI for automatic branch sync
feat: add team-tier files from Superapp and Strium unification
chore: remove CLAUDE.group.md, nested .claude/, and sync workflow
Use $SHARED_REL for git pathspecs instead of absolute $SHARED_DIR, and use $CONFIG_BRANCH variable in branch name instead of hardcoding superapp.
Replace fixed /tmp/migrate_check sentinel with mktemp to avoid collisions, and use relative path for git ls-files/git rm --cached.
Replace outdated .team.* reference with current shared config terminology.
Local files live in .claude-lib/local/ (gitignored) and get a .local suffix in .claude/, same as project files but never committed. Local overrides both shared and project when the same base name exists.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the repository’s Claude Code configuration to a shared, subtree-managed setup under .claude-lib/shared, removing the previously committed .claude/ config and updating ignores accordingly.
Changes:
- Ignore generated/local Claude config directories (
.claude,.claude-lib/shared-overridden,.claude-lib/local) in.gitignore. - Remove the committed
.claude/settings/agents and add shared config content under.claude-lib/shared/(rules, skills, agents, commands, hooks, scripts). - Add/refresh project-tier overrides under
.claude-lib/project/(rules + skills) to tailor shared config to app-sdk needs.
Reviewed changes
Copilot reviewed 93 out of 105 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| .gitignore | Ignores generated Claude config directories and local overrides. |
| .claude/settings.json | Removes previously committed Claude settings (now expected to be generated/managed elsewhere). |
| .claude/agents/security-reviewer.md | Removes old project-specific agent definition in favor of shared config. |
| .claude/agents/code-reviewer.md | Removes old project-specific agent definition in favor of shared config. |
| .claude-lib/shared/README.md | Documents shared-config setup and workflow for subtree install/unpack/pack/push. |
| .claude-lib/shared/rules/web3.md | Adds shared Web3 standards/rules. |
| .claude-lib/shared/rules/typescript.md | Adds shared TypeScript standards/rules. |
| .claude-lib/shared/rules/testing.md | Adds shared testing requirements. |
| .claude-lib/shared/rules/tanstack.md | Adds shared TanStack patterns guidance. |
| .claude-lib/shared/rules/tailwind.md | Adds shared Tailwind conventions/rules. |
| .claude-lib/shared/rules/state-management.md | Adds shared Zustand/state-management rules. |
| .claude-lib/shared/rules/security.md | Adds shared frontend security rules. |
| .claude-lib/shared/rules/react.md | Adds shared React/JSX standards. |
| .claude-lib/shared/rules/react-hooks.md | Adds shared React hooks patterns. |
| .claude-lib/shared/rules/e2e.md | Adds shared Playwright E2E rules. |
| .claude-lib/shared/rules/design-ux-motion.md | Adds shared motion/animation UX rules. |
| .claude-lib/shared/rules/design-ux-interaction.md | Adds shared interaction design rules. |
| .claude-lib/shared/rules/design-ux-conventions.md | Adds shared UX conventions and design-system rules. |
| .claude-lib/shared/rules/design-ux-a11y.md | Adds shared accessibility (a11y) UX rules. |
| .claude-lib/shared/rules/contributing.md | Documents how to contribute changes back to the shared config repo. |
| .claude-lib/shared/rules/coding-style.md | Adds shared coding-style/immutability/error-handling rules. |
| .claude-lib/shared/hooks/design-ux-pre-commit-ux-prompt.md | Adds a Claude hook definition to prompt UX review before commits involving UI files. |
| .claude-lib/shared/commands/tdd.md | Adds shared /tdd command guidance. |
| .claude-lib/shared/commands/e2e.md | Adds shared /e2e command guidance. |
| .claude-lib/shared/commands/e2e-maintenance.md | Adds shared /e2e-maintenance command guidance. |
| .claude-lib/shared/commands/design-ux-review-ux.md | Adds shared /review-ux command guidance. |
| .claude-lib/shared/commands/design-ux-review-motion.md | Adds shared /review-motion command guidance. |
| .claude-lib/shared/commands/claude-config-pull.md | Adds shared /claude-config-pull command guidance. |
| .claude-lib/shared/commands/claude-config-push.md | Adds shared /claude-config-push command guidance. |
| .claude-lib/shared/agents/tdd-guide.md | Adds shared TDD agent. |
| .claude-lib/shared/agents/security-reviewer.md | Adds shared security reviewer agent. |
| .claude-lib/shared/agents/e2e-runner.md | Adds shared E2E runner agent. |
| .claude-lib/shared/agents/code-reviewer.md | Adds shared code reviewer agent. |
| .claude-lib/shared/agents/build-error-resolver.md | Adds shared build error resolver agent. |
| .claude-lib/shared/.scripts/install.sh | Adds installer script to set up subtree + generate .claude/. |
| .claude-lib/shared/.scripts/migrate.sh | Adds migration script to move existing .claude/ into project tier. |
| .claude-lib/shared/.scripts/unpack.sh | Adds script to generate .claude/ from shared/project/local tiers. |
| .claude-lib/shared/.scripts/pack.sh | Adds script to reverse unpack: .claude/ → shared/project/local tiers. |
| .claude-lib/shared/.scripts/push.sh | Adds script to push shared changes back to the source config repo via subtree push. |
| .claude-lib/shared/.gitignore | Adds ignores for local-only/shared-repo artifacts (docs/report/local overrides). |
| .claude-lib/shared/.gitattributes | Normalizes shell-script line endings to LF. |
| .claude-lib/shared/.branch | Sets default shared-config branch selection (e.g. frontend). |
| .claude-lib/shared/.github/workflows/sync-to-projects.yml | Adds shared-config automation workflow content (stored inside the subtree). |
| .claude-lib/shared/.github/workflows/sync-groups.yml | Adds shared-config automation workflow content (stored inside the subtree). |
| .claude-lib/shared/.github/workflows/promote-team-files.yml | Adds shared-config promotion workflow content (stored inside the subtree). |
| .claude-lib/shared/skills/typeset/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/teach-impeccable/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/side-effect/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/review-renovate-prs/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/reflect/SKILL.md | Updates shared skill guidance text/examples. |
| .claude-lib/shared/skills/quieter/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/pr-summary/SKILL.md | Updates shared PR summary skill output guidance. |
| .claude-lib/shared/skills/polish-styling/SKILL.md | Adds shared Tailwind-polish skill definition. |
| .claude-lib/shared/skills/normalize/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/learn/SKILL.md | Updates learned-skill output location to be project-local. |
| .claude-lib/shared/skills/frontend-design/reference/ux-writing.md | Adds shared frontend-design reference doc. |
| .claude-lib/shared/skills/frontend-design/reference/typography.md | Adds shared frontend-design reference doc. |
| .claude-lib/shared/skills/frontend-design/reference/spatial-design.md | Adds shared frontend-design reference doc. |
| .claude-lib/shared/skills/frontend-design/reference/responsive-design.md | Adds shared frontend-design reference doc. |
| .claude-lib/shared/skills/frontend-design/reference/motion-design.md | Adds shared frontend-design reference doc. |
| .claude-lib/shared/skills/frontend-design/reference/color-and-contrast.md | Adds shared frontend-design reference doc. |
| .claude-lib/shared/skills/extract/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/distill/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/design-dev-tools/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/debugging-with-chrome/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/debugging-with-chrome/PATTERNS.md | Adds shared debugging patterns reference. |
| .claude-lib/shared/skills/critique/reference/cognitive-load.md | Adds shared critique reference doc. |
| .claude-lib/shared/skills/creating-ui-components/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/colorize/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/bolder/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/arrange/SKILL.md | Adds shared skill definition. |
| .claude-lib/shared/skills/achievements/SKILL.md | Updates shared skill guidance text. |
| .claude-lib/project/skills/side-effect/SKILL.md | Adds project-tier override/variant of side-effect skill tailored to app-sdk paths. |
| .claude-lib/project/skills/code-review/SKILL.md | Adds project-tier code-review skill wiring to shared agents/workflow. |
| .claude-lib/project/rules/web3.md | Adds project-tier Web3 rules tailored to app-sdk. |
| .claude-lib/project/rules/unit-test.md | Adds project-tier unit testing rules tailored to app-sdk. |
| .claude-lib/project/rules/typescript.md | Adds project-tier TypeScript rules tailored to app-sdk (aliases, formatting, etc.). |
| .claude-lib/project/rules/security.md | Adds project-tier SDK security rules tailored to app-sdk. |
| .claude-lib/project/rules/e2e.md | Adds project-tier E2E rules tailored to app-sdk test structure. |
| .claude-lib/project/rules/coding-style.md | Adds project-tier coding-style rules tailored to app-sdk conventions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+14
| CONFIG_REMOTE="claude-config" | ||
| CONFIG_REMOTE_URL="https://github.com/StartaleGroup/claude-config-shared.git" | ||
| CONFIG_BRANCH="${1:-$(cat "$SHARED_DIR/.branch" 2>/dev/null)}" | ||
|
|
||
| if [ -z "$CONFIG_BRANCH" ]; then |
Comment on lines
+48
to
+52
| # Copy standalone files (settings.json, etc.) | ||
| for file in "$SHARED_DIR"/*.json; do | ||
| [ -f "$file" ] || continue | ||
| cp "$file" "$TARGET_DIR/$(basename "$file")" | ||
| done |
| Output: list of potential duplications with suggested replacements. | ||
|
|
||
| ### 1. Accessibility (a11y) | ||
| Check each file against .claude/rules/design-and-ux/a11y.team.md. |
| - "Do dynamic content updates use aria-live?" | ||
|
|
||
| ### 2. Animation & Motion | ||
| Check each file against .claude/rules/design-and-ux/motion.team.md. |
| for its type?" | ||
|
|
||
| ### 3. Interaction Design | ||
| Check each file against .claude/rules/design-and-ux/interaction.team.md. |
| - "Do async actions revert on failure with an error message?" | ||
|
|
||
| ### 4. UX Patterns | ||
| Check each file against .claude/rules/design-and-ux/ux.team.md. |
| Output: list of potential duplications with suggested replacements. | ||
|
|
||
| ### 1. Animation & Motion | ||
| Check each file against .claude/rules/design-and-ux/motion.team.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-config-shared.claude-lib/project/config (agents, settings, skills) now covered by shared configResolves FRO-510
How did you test your changes?
Verified Claude Code loads shared config correctly in the workspace.