Skip to content

CI ERROR: Instance of 'KafkaConsumer' has no 'task_done' member #21

Description

@jschoewe

StackStorm CI is returning the following error:

CI ERROR: Instance of 'KafkaConsumer' has no 'task_done' member

This task_done function is used in the following sensors:

  • sensors/message_sensor.py
  • sensors/gcp_message_sensor.py

This function was also dropped from KafkaConsumer some time ago (idk when exactly, sometime around v1):


Based on the link above, it sounds like there is no longer a need for a task_done function of any kind because the later versions of kafka can detect when a message has been delivered instead of waiting for a manual ack.

I don't know if that means that those task_done lines can just be removed and the older functions will work the same as they used to in the newer version or if those older functions also changed, but I've never used kafka before and don't have a way of testing this. I'm just trying to fix CI build errors in all stackstorm packs in preparation for the 3.9 release

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions