fix: migrate reusable-satis-publish to 1Password secrets - #108
Merged
Conversation
Load SATISBOSS_KEY from op://s360-cicd/satis/key via OP_SERVICE_ACCOUNT_TOKEN so callers only need the single org-level 1Password secret. Co-Authored-By: Claude
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable Satis publish workflow to source the SatisBoss bearer token via 1Password instead of requiring it to be provided directly as a GitHub Actions secret, aligning secret distribution with the org’s 1Password-based pattern.
Changes:
- Replaces the
workflow_callsecretSATISBOSS_KEYwithOP_SERVICE_ACCOUNT_TOKEN. - Adds 1Password
configure+load-secretssteps to loadSATISBOSS_KEYfromop://s360-cicd/satis/key. - Switches the curl auth token wiring to use the loaded environment variable (
env.SATISBOSS_KEY).
Comment on lines
42
to
45
| secrets: | ||
| SATISBOSS_KEY: | ||
| description: 'Bearer token minted on SatisBoss (/api/keys/mint)' | ||
| OP_SERVICE_ACCOUNT_TOKEN: | ||
| description: '1Password service account token — loads SATISBOSS_KEY from s360-cicd vault' | ||
| required: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SATISBOSS_KEYsecret withOP_SERVICE_ACCOUNT_TOKENSATISBOSS_KEYfromop://s360-cicd/satis/keypantheon-github-workflowsv3.0.1 Satis publish (currently 401 becauseSATISBOSS_KEYis not an org secret)Test plan
satis-publish.ymlinpantheon-github-workflowsto new SHA +OP_SERVICE_ACCOUNT_TOKEN→ manually trigger Satis publish for v3.0.1🤖 Generated with Claude Code