fix: pre-flight uses terminus env:info, not connection:info, for conn… - #102
Merged
Merged
Conversation
…ection_mode field; self-pin internal refs to v3.2.5 `connection_mode` lives on `terminus env:info`, NOT on `terminus connection:info` (which returns git/sftp connection URLs and commands only). v3.2.4 shipped with the wrong subcommand: MODE=$(terminus connection:info ... --field=connection_mode) Terminus exits 1 with "The requested field, 'connection_mode', is not defined." The fix is a one-word change: MODE=$(terminus env:info ... --field=connection_mode) Why this slipped past v3.2.4's Yale Health pre-merge validation: the original code had `2>/dev/null || echo ""` swallowing terminus errors, so MODE was always empty, the `!= "git"` check always tripped, and `connection:set git` ran defensively every single time — masking the broken field query. Copilot's review on PR #101 correctly flagged the stderr suppression and we removed it. That surfaced this real bug on the first v3.2.5-released consumer deploy (Yale Health, immediately after the plugin v2.0.18 release). Out-of-scope but confirmed sound: `terminus connection:info ... --field=git_url` in the verify-after-push step is correct — `git_url` IS on `connection:info`. Only the pre-flight call was wrong. Self-pin internal @v3.2.4 → @v3.2.5 across all four reusable deploy workflows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ection_mode field; self-pin internal refs to v3.2.5
connection_modelives onterminus env:info, NOT onterminus connection:info(which returns git/sftp connection URLs and commands only). v3.2.4 shipped with the wrong subcommand:MODE=$(terminus connection:info ... --field=connection_mode)
Terminus exits 1 with "The requested field, 'connection_mode', is not defined." The fix is a one-word change:
MODE=$(terminus env:info ... --field=connection_mode)
Why this slipped past v3.2.4's Yale Health pre-merge validation: the original code had
2>/dev/null || echo ""swallowing terminus errors, so MODE was always empty, the!= "git"check always tripped, andconnection:set gitran defensively every single time — masking the broken field query. Copilot's review on PR #101 correctly flagged the stderr suppression and we removed it. That surfaced this real bug on the first v3.2.5-released consumer deploy (Yale Health, immediately after the plugin v2.0.18 release).Out-of-scope but confirmed sound:
terminus connection:info ... --field=git_urlin the verify-after-push step is correct —git_urlIS onconnection:info. Only the pre-flight call was wrong.Self-pin internal @v3.2.4 → @v3.2.5 across all four reusable deploy workflows.