Skip to content

fix: main.rs, log error#86

Merged
Spagett1 merged 1 commit into
Spagett1:masterfrom
prochac:patch-1
Feb 6, 2025
Merged

fix: main.rs, log error#86
Spagett1 merged 1 commit into
Spagett1:masterfrom
prochac:patch-1

Conversation

@prochac

@prochac prochac commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

The error had format w/o argument. The error variable was unused.

The error had format w/o argument. The `error` variable was unused.
@gbin

gbin commented Jan 1, 2025

Copy link
Copy Markdown

Got that from the AUR package on Arch along some warnings:

error: 1 positional argument in format string, but no arguments were given
   --> src/main.rs:532:88
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |                                                                                        ^^

warning: unused imports: `ImageSource` and `epaint::ColorImage`
  --> src/main.rs:12:27
   |
12 | use eframe::{egui::{self, ImageSource}, epaint::ColorImage};
   |                           ^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `error`
   --> src/main.rs:532:13
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |             ^^^^^ help: if this is intentional, prefix it with an underscore: `_error`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `pineflash` (bin "pineflash") generated 2 warnings
error: could not compile `pineflash` (bin "pineflash") due to 1 previous error; 2 warnings emitted
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'pineflash-git-0.5.5+2.r309.20241230.1cbe554-1':
error: packages failed to build: pineflash-git-0.5.5+2.r309.20241230.1cbe554-1

@prochac

prochac commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

@prochac

prochac commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

Probably caused by this:
#83

@gbin

gbin commented Jan 3, 2025

Copy link
Copy Markdown

@acuteaangle 🥺

@acuteaangle

Copy link
Copy Markdown
Contributor

Welp, that’s incredibly embarrassing ;-;
I had caught this locally, but must have skipped a git add before amending the commit :/

Sorry for the build error :c

Adding ‘learn how pre-commit works’ to my todo

acuteaangle added a commit to acuteaangle/pineflash that referenced this pull request Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run
tests, should they be added in the future) on Windows, MacOS, and Linux.

This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83)
from recurring in the future.

Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
acuteaangle added a commit to acuteaangle/pineflash that referenced this pull request Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run
tests, should they be added in the future) on Windows, MacOS, and Linux.

This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83)
from recurring in the future.

Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
@prochac

prochac commented Jan 25, 2025

Copy link
Copy Markdown
Contributor Author

@Spagett1 ping
It won't take more than 10 seconds of your time :)

@sammcj

sammcj commented Jan 28, 2025

Copy link
Copy Markdown

Confirmed this fixes the problems with building on macOS.

@Spagett1

Spagett1 commented Feb 6, 2025

Copy link
Copy Markdown
Owner

Thank you for the patch, I was unaware of master failing to build, appreciate the help and sorry for the delay in merging.

@Spagett1 Spagett1 merged commit 897bad8 into Spagett1:master Feb 6, 2025
@prochac

prochac commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for the patch, I was unaware of master failing to build, appreciate the help and sorry for the delay in merging.

Thanks. Btw, there is PR #88 that should prevent this type of mistake in the future

acuteaangle added a commit to acuteaangle/pineflash that referenced this pull request Mar 23, 2025
This adds GitHub Actions integration to automatically build (and run
tests, should they be added in the future) on Windows, MacOS, and Linux.

This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83)
from recurring in the future.

Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants