build: fix cargo-audit/cargo-deny CI drift (yanked spin, quick-xml advisories, MSRV)#50
Merged
Merged
Conversation
…visories, MSRV) Three unrelated pieces of dependency/tooling drift accumulated since the CI gates last ran clean, surfaced while opening an unrelated PR: - `cargo deny check` failed: `spin 0.9.8` (transitive via wiremock/deadpool/lazy_static) was yanked upstream. Bumped to 0.9.9. - `cargo-audit`'s own install broke: `rustsec/audit-check@v2` runs a bare `cargo install cargo-audit`, which re-resolves cargo-audit's dependencies fresh on every run — a transitive `kstring` bump now requires a newer rustc than the workspace's pinned 1.95.0. Replaced the action with a manual `cargo install cargo-audit --locked` (pins to cargo-audit's own committed lockfile) + a plain `cargo audit` step, mirroring `just audit`. - Two new advisories on a fresh `cargo audit`/`cargo deny` run: RUSTSEC-2026-0195 / RUSTSEC-2026-0194 (quick-xml 0.39.4). Bumped `anyhow` 1.0.102 -> 1.0.104 to clear RUSTSEC-2026-0190 in passing; quick-xml is a build-time-only proc-macro dependency of wayland-scanner (transitive via arboard's Wayland clipboard support) with no newer wayland-scanner resolvable yet, so it's added to the ignore list (CI + deny.toml + justfile), matching the existing paste/rsa rationale comments. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unrelated CI/dependency drift discovered while opening #49, blocking merge for reasons that have nothing to do with that PR's diff:
cargo deny checkfailed:spin 0.9.8(transitive via wiremock/deadpool/lazy_static, dev-only) was yanked upstream. Bumped to0.9.9.cargo-audit's own install broke in CI:rustsec/audit-check@v2runs a barecargo install cargo-audit, which re-resolves cargo-audit's own dependencies fresh every run — a transitivekstringbump now requires a newer rustc than the workspace's pinned1.95.0. Replaced the action with a manualcargo install cargo-audit --locked(pins to cargo-audit's own committed lockfile) + a plaincargo auditstep, mirroringjust auditand dropping the now-unusedchecks: writepermission.cargo audit/cargo denyrun also surfaced two new advisories:RUSTSEC-2026-0195/RUSTSEC-2026-0194(quick-xml 0.39.4, build-time-only proc-macro dep ofwayland-scanner, transitive via arboard's Wayland clipboard support — no newerwayland-scannerresolvable yet underwayland-client's current constraint). Added to the ignore list in CI +deny.toml+justfile, matching the existingpaste/rsarationale comments. Bumpedanyhow1.0.102 → 1.0.104 in passing, clearingRUSTSEC-2026-0190.Test plan
cargo build --workspacecargo test --workspace --all-targets— all greencargo fmt --all -- --checkcargo deny check— advisories/bans/licenses/sources all okcargo audit --ignore RUSTSEC-2024-0436 --ignore RUSTSEC-2026-0002 --ignore RUSTSEC-2023-0071 --ignore RUSTSEC-2026-0195 --ignore RUSTSEC-2026-0194— cleanreuse lint— compliant🤖 Generated with Claude Code