Skip to content

🌱 Fix/fix pr verify#227

Open
garloff wants to merge 3 commits intomainfrom
fix/fix-pr-verify2
Open

🌱 Fix/fix pr verify#227
garloff wants to merge 3 commits intomainfrom
fix/fix-pr-verify2

Conversation

@garloff
Copy link
Copy Markdown
Member

@garloff garloff commented May 6, 2026

Old pr-verify from kubebuilder-release-tools won't work any more.
Replace, as suggested by
https://github.com/kubernetes-sigs/kubebuilder-release-tools#pr-verification-github-action-deprecated

garloff added 3 commits May 6, 2026 22:10
The latter is outdated and included a reference to grc.io that broke.
So use directly a working container.

Assisted-by: Qwen3.6
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff garloff requested review from janiskemper and jschoone May 6, 2026 22:12
@garloff garloff self-assigned this May 6, 2026
@garloff garloff added bug Something isn't working Container Issues or pull requests relevant for Team 2: Container Infra and Tooling labels May 6, 2026
@garloff garloff mentioned this pull request May 6, 2026
@garloff
Copy link
Copy Markdown
Member Author

garloff commented May 6, 2026

My understanding is that github still runs the old workflow here, which is why the CI will keep flagging it.
I believe we need to ignore it.

@janiskemper
Copy link
Copy Markdown
Member

I'm really not the CI expert. I hope @jschoone can review!

@garloff garloff requested review from schmidax and schneidarno May 7, 2026 20:57
@garloff
Copy link
Copy Markdown
Member Author

garloff commented May 7, 2026

Trouble is that we have a workflow that no longer works.See link in the first comment.
The consequence is that all PRs are flagged as not passing.
My change discards the broken workflow and instead uses the one that the kubebuilder folks have installed instead.
The CI however starts with the previous state, thus this one is flagged as failing and I believe we need to ignore this.
I'm no github wizard either, so if someone has a high level of expertise, I'm happy to learn...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Container Issues or pull requests relevant for Team 2: Container Infra and Tooling

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants