Conversation
We do this because the mere existence of a openstack-hosted-control-plane-1-34-v0-sha-0ewkztd tag in the registry confused csctl and prevented us from releasing a new cluster stack. So, we tolerate dashes in clusterstack names now by being more robust in parsing, So, if we don't have '-v' at the right position in the string spliited by '-', we look for a '-v' further to the right. We then assume that the extra dashes belong to the name and process accordingly. The string parsing code is not very beautiful, but has been tested successfully. This fixes #220. Signed-off-by: Kurt Garloff <kurt@garloff.de>
This is the main thing and it should be hashed, as changes there are consequential. Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff
added
bug
Member
Author
|
This patch needs to be done against CSO as well, it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had screwed the release of
openstack-scs2-1-34-v2, as it contained a clusterClass 1.33.Now, pushing out a
-v3using the normalcsctl create -m stablewould not work, as csctl thinks we have the same release. It looks at all components and compares hashes to make that determination.All components?
No, a collection of clusterClass populated by inflexible attributes does not stop resisting being ignored ...
csctl did not hash the most important thing ...
SovereignCloudStack/cluster-stacks#265 (comment)
This patchset addresses this.
Needs review!
Possibly, CSO has similar logic that needs to change as well?