Skip to content

fix: namespace holders by allow-list, parsed text names, Symbol trust after code text, shared roots (R51-RX9) - #453

Merged
Sorte1 merged 4 commits into
mainfrom
fix/r51-rx9
Nov 19, 2026
Merged

Sorte1 merged 4 commits into
mainfrom
fix/r51-rx9

Conversation

@Sorte1

@Sorte1 Sorte1 commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Fixes the four findings of review/r4-a25rr7.md (R51-RX9).

  • F1: may_hold_global is an allow-list. A holder is proven not to be the global object only when it is a fixed local binding (not rebound through the global object, not named by code text, not shared with another input) initialised by a literal with no __proto__ key or accessor, whose every use is a member access, a resolved method call, a test or typeof, and whose __proto__ or unresolved-key writes store values that are proven too. Free names and this may hold it. Arrays, functions and primitives also need the built-in prototype chains to be unchanged: no built-in prototype is obtained as a value, by __proto__, getPrototypeOf, a descriptor reader, an unresolved key on a constructor, with, or a code text the literal-text judge cannot clear. The scan runs again whenever the settle loop finds new rebound roots; writes inside recognised protection blocks and machinery do not count as rebinding. A numeric or fresh-Symbol() key cannot name a namespace, so such reads give the global kind instead.
  • F2: rebound globals are found by the same parsed-text judgement the watched names use (names_reach_text), so escapes and nested runners count. Nested texts are judged in every lane.
  • F3: Symbol stays trusted only while every code text that may run is a literal that does not name Symbol after parsing; any other runner text drops the trust.
  • F4: top-level bindings is_shared_global reports are opaque before the first analysis, count as a global source, and every fixedness check under calls/agnostic/ goes through rebound(), which includes them.

--unsafe: F2, F3 and F4 apply in both lanes. For F1 --unsafe keeps its premise that built-in prototypes are not patched (q-rx9-a15); the holder proofs apply in both lanes. The other-input key rebinding row (rx9-m21) is under the keyed-rebind premise under --unsafe.

Rows: the 26 fin repros and 41 multi-input cases are in rename_a25rr. The recursive-helper row in dynamic_reach_rows decodes again, as it did before the namespace-by-key rule.

Measured against main: obfuscator BASELINEs identical (io, versions, relayer), bundle-matrix identical, Krunker and game.js byte-identical in both lanes (instructions +5 to 6% on 0.20 and 2.6.9 default, under 3% elsewhere). Full sweep: no case got worse in either lane; every case failing with this branch fails the same way on main. Reviewer probe dirs: no default-lane difference left except the k1 error-text rows. Wasm 16,153,413 bytes before the last rebase.

@Sorte1
Sorte1 merged commit e7bc3b5 into main Nov 19, 2026
9 checks passed
@Sorte1
Sorte1 deleted the fix/r51-rx9 branch November 19, 2026 09:41

This branch was successfully deployed

1 active deployment
preview — 49b93c00 Deployed Nov 19, 2026 by Sorte1 via deploy #1303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant