Repository navigation
Conversation
… and calls cannot change it
…es with the nested-object proofs
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F1 to F3 from the OX-R1 review (#439's nested-object decision in dead.rs, wrong output in both lanes).
A nested const object now decides a dead branch only in these cases:
key: valuewith a static identifier or string key, and none is__proto__in any spelling. Getters, methods, spread and computed keys are refused, as before.this,super,argumentsoreval, so a call through the object cannot write to it or hand it back. This covers arrows inside methods ando.self().k = ....--unsafea read may also name a key thatObject.prototypedoes not define, since built-ins are assumed unpatched. A dead-code copy readsA.fromCharCode, and refusing that read brokernd013-n1--objects.o.valueOf().k = ...ando.__defineGetter__(...)are refused in both lanes, and so is a patchedObject.prototypemethod in the default lane.F6, the timer note's premise in the README, is already covered on main by #446 and #448, so this PR leaves it alone.
Rows in obfuscator_sweep_rows.rs cover every repro and variant from the review, checked against node in both lanes, plus one row showing that a plain nested object still decides.
Full sweep (3,465 cases, before the rebase): every verdict in both lanes is the same as main @16463ffa, with no pass to fail and no kept to fail. Krunker samples are byte-identical to main in both lanes. Obfuscator BASELINE drift tests pass. Wasm is 16,063,946 bytes, under the current cap.