test: NetworkSwitcher/ButtonGroup/SorobanInvokeButton coverage (issue #346) - #432
Open
BernardOnuh wants to merge 1 commit into
Open
Conversation
- Assert the loading label shows "Invoking {method}…" while an
invocation is in flight, and the generic "Invoking…" when a custom
label is provided
- Verify the tooltip prop renders as the button's title when connected
and falls back to the connect hint title when disconnected
- Verify the result container caps its height via maxResultHeight
(default 200px and custom values)
- Harden ButtonGroup border-radius tests to assert the child selector
classes that collapse the shared radius on sibling buttons
|
@BernardOnuh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing test coverage requested in #346. Most scenarios named in this issue (Alt+N shortcut, mismatch badge, NetworkSwitcher localStorage persistence, ButtonGroup icons and href-disabled behavior) were already covered by existing tests, so this PR targets the genuine gaps only.
Changes
Test output
``'
✓ src/components/ui/Button.test.tsx (30 tests)
✓ src/components/SorobanInvokeButton.test.tsx (16 tests)
Test Files 2 passed (2)
Tests 46 passed (46)
``'
Closes #346