feat(cli): render invited players with profile URLs in recruit delivery#164
Merged
Conversation
`ccas recruit --report` and the interactive confirm previously emitted only bare usernames, giving no way to vet a player before inviting. They now render the same review block the recruitment out file uses — a space-separated username line (paste-ready for invites) followed by one `<username> <profile-url>` line per player — and copy that block to the clipboard, not just the usernames. Everything routes through a single source so the three renderings can't drift: ApiPlayer.getProfileUrl -> profileLine -> profileReviewBlock, used by the out-file formatter, `--report`, and the confirm delivery. This also removes a divergent hand-rolled rendering in showReport (it logged bare URLs on their own lines) — showReport is now pure data-fetch and the report app echoes the shared formatter's output line-by-line. CLI-only; no server or schema change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ccas recruit --reportand the interactive confirm previously emitted only bare usernames — no way to vet a player before inviting. They now render the same review block the recruitment out file uses:— a space-separated username line (paste-ready for invites) then one
<username> <profile-url>line per player — and copy that block to the clipboard, not just the usernames.Single source so the three renderings can't drift:
ApiPlayer.getProfileUrl → profileLine → profileReviewBlock, used by the out-file formatter,--report, and the confirm delivery. Also removed a divergent hand-rolled rendering inshowReport(logged bare URLs on their own lines); it's now pure data-fetch and the report app echoes the shared formatter line-by-line.Fixes
--report/ confirm copied only usernames and showed no profile URLs for manual inspection.showReportconsole output diverged from the out file (bare URLs vsusername url).Testing
sbt testgreen (pre-push hook).--stdoutpaths.Notes
ccasbinary.--stdoutpiping mode stays a bare newline list.🤖 Generated with Claude Code