SONARJAVA java:S6204 should not raise an issue when addFirst/addLast/removeFirst/removeLast is called on the list

Author: Andreas

java-checks-test-sources/default/src/main/java/checks/CollectorsToListCheckSample.java

@@ -119,6 +119,26 @@ void compliant() {
       .collect(Collectors.toList()); // Compliant, list5 needs to be mutable
 
     list5.removeIf(s -> true);
+
+    List<String> list6 = Stream.of("B", "C", "D")
+      .collect(Collectors.toList()); // Compliant, list6 needs to be mutable
+
+    list6.addFirst("A");
+
+    List<String> list7 = Stream.of("A", "B", "C")
+      .collect(Collectors.toList()); // Compliant, list7 needs to be mutable
+
+    list7.addLast("D");
+
+    List<String> list8 = Stream.of("A", "B", "C")
+      .collect(Collectors.toList()); // Compliant, list8 needs to be mutable
+
+    list8.removeFirst();
+
+    List<String> list9 = Stream.of("A", "B", "C")
+      .collect(Collectors.toList()); // Compliant, list9 needs to be mutable
+
+    list9.removeLast();
   }
 
   void addX() {

java-checks/src/main/java/org/sonar/java/checks/CollectorsToListCheck.java

@@ -58,7 +58,8 @@ public class CollectorsToListCheck extends AbstractMethodDetection implements Ja
 
   private static final MethodMatchers LIST_MODIFICATION_METHODS = MethodMatchers.create()
     .ofSubTypes("java.util.List")
-    .names("add", "addAll", "remove", "removeAll", "retainAll", "replaceAll", "set", "sort", "clear", "removeIf")
+    .names("add", "addAll", "remove", "removeAll", "retainAll", "replaceAll", "set", "sort", "clear", "removeIf",
+      "addFirst", "addLast", "removeFirst", "removeLast")
     .withAnyParameters()
     .build();