Skip to content

Commit bf899bf

Browse files
SONARJAVA-6099 Fix FP on S1135 due to off-by-one error (#5438)
1 parent 9295325 commit bf899bf

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

java-checks-test-sources/default/src/main/java/checks/TodoTagPresenceCheckSample.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
// Noncompliant@+1
2828
//// TODO Explanation
2929

30+
// Spanish todos
31+
3032
// PreTodo
3133
// toDomain
3234
package checks;

java-checks/src/main/java/org/sonar/java/checks/CommentContainsPatternChecker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ private static boolean isLetterAround(String line, String pattern) {
3838
int end = start + pattern.length();
3939

4040
boolean pre = start > 0 && Character.isLetter(line.charAt(start - 1));
41-
boolean post = end < line.length() - 1 && Character.isLetter(line.charAt(end));
41+
boolean post = end < line.length() && Character.isLetter(line.charAt(end));
4242

4343
return pre || post;
4444
}

0 commit comments

Comments
 (0)