Repository navigation
test: fail waiting tests on a failed solve; pin swap moves - #207
Merged
Merged
Conversation
parallel_local_search, parallel_list_local_search and scalar_runtime_publication waited for Completed and skipped every other event. A job keeps its event channel open until it is deleted, so a solve that failed left the test blocked in blocking_recv forever instead of failing. They now pass over best-solution and progress events only, and panic with the error on Failed and with the event on anything else; a solve that cannot prepare its phases now fails these tests in seconds.
A swap cursor that emitted no moves passed every test. A solve configured with only swap moves now starts from two tasks on each other's cheaper worker and asserts that the search exchanges them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base
main@f70f37dc, two test-only commits:2d6312c3parallel_local_search, parallel_list_local_search and scalar_runtime_publication skipped every event but Completed; a failed solve left them blocked inblocking_recvforever (the job keeps its channel open until deleted). They now panic with the error on Failed and on any unexpected event. Checked: a build whose phases cannot prepare now fails these tests in seconds instead of hanging.c5414198a swap cursor emitting no moves passed every test. A swap-only solve now asserts the exchange. MutationSelf::Swap(_cursor) => Nonefails it.Gate (fmt, clippy, doc-names file-length facade-reachability public-api deps, rustdoc, examples, workspace all-feature tests, doctests): EXIT 0, 1582 passed, 0 failed, 71 result lines.