Post milestone3m#744
Draft
SharonStrats wants to merge 69 commits intomainfrom
Draft
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
TallTed
reviewed
Apr 30, 2026
…into post-milestone3m
…into post-milestone3m
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…into post-milestone3m
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 53 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
src/widgets/forms.js:168
- This section appears to have a structural/syntax break: after the
try/catchblock the file continues with a stray parameter list (container, already, subject, ...) which looks like the start of another function signature, implying missing braces/accidental deletion around the end of the group renderer and start of the Options renderer. As-is, this likely makesforms.jsinvalid JS and will prevent the module from loading.
README.md:433 - The prompt history entry includes an absolute local filesystem path (
/Users/sharon/...). This isn’t portable and will be confusing for other contributors; please change it to a repo-relative path (e.g.src/media/media-capture.ts).
* Claude Sonnet 4.6: Make the drop down as a list under the input field and enlarge the pop up, make it higher, adjustable to fit the drop down. And make the drop down arrow area larger
* GPT-5.4 Model: can you wire up the keyboard interactions and aria attributes for Select?
* GPT-5.4 Model: Take the code from /Users/sharon/2025Dev/solid-ui/src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 53 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
README.md:433
- This prompt-history entry includes an absolute local filesystem path (
/Users/...), which is not portable and can unintentionally leak developer machine details into published docs. Replace it with a repo-relative path (e.g.,src/media/media-capture.ts) or omit the path entirely.
* GPT-5.4 Model: can you wire up the keyboard interactions and aria attributes for Select?
* GPT-5.4 Model: Take the code from /Users/sharon/2025Dev/solid-ui/src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…into post-milestone3m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the v2 web component surface (new Button/Select/Combobox/PhotoCapture and introduces a manifest-driven build/export pipeline to keep webpack entries and package.json subpath exports in sync, alongside a few widget/login behavior fixes and new unit tests.
Changes: