Skip to content

Post milestone3m#744

Draft
SharonStrats wants to merge 69 commits intomainfrom
post-milestone3m
Draft

Post milestone3m#744
SharonStrats wants to merge 69 commits intomainfrom
post-milestone3m

Conversation

@SharonStrats
Copy link
Copy Markdown
Contributor

@SharonStrats SharonStrats commented Apr 29, 2026

This PR expands the v2 web component surface (new Button/Select/Combobox/PhotoCapture and introduces a manifest-driven build/export pipeline to keep webpack entries and package.json subpath exports in sync, alongside a few widget/login behavior fixes and new unit tests.

Changes:

  • Introduces scripts/component-manifest.mjs + sync/watch scripts, updates webpack config to consume manifest entries, and updates package.json exports/scripts accordingly.
  • Adds new Lit-based components (actions/button, forms/select, forms/combobox, media/photoCapture) with READMEs and unit tests; reorganizes v2 layout/auth component entrypoints.
  • Fixes/adjusts runtime behavior: prevent concurrent checkbox updates, normalize dropped URIs and stop propagation on DnD, broaden drop targets for attachments, and harden getUserRoles() for missing session/current user.

@SharonStrats SharonStrats self-assigned this Apr 29, 2026
@SharonStrats SharonStrats moved this to In progress in SolidOS NLNet UI Apr 29, 2026
Comment thread README.md Outdated
SharonStrats and others added 15 commits May 5, 2026 20:36
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 41 out of 53 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

src/widgets/forms.js:168

  • This section appears to have a structural/syntax break: after the try/catch block the file continues with a stray parameter list (container, already, subject, ...) which looks like the start of another function signature, implying missing braces/accidental deletion around the end of the group renderer and start of the Options renderer. As-is, this likely makes forms.js invalid JS and will prevent the module from loading.
    README.md:433
  • The prompt history entry includes an absolute local filesystem path (/Users/sharon/...). This isn’t portable and will be confusing for other contributors; please change it to a repo-relative path (e.g. src/media/media-capture.ts).
* Claude Sonnet 4.6: Make the drop down as a list under the input field and enlarge the pop up, make it higher, adjustable to fit the drop down. And make the drop down arrow area larger

* GPT-5.4 Model: can you wire up the keyboard interactions and aria attributes for Select?

* GPT-5.4 Model: Take the code from /Users/sharon/2025Dev/solid-ui/src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.

Comment thread src/widgets/forms.js Outdated
Comment thread src/v2/components/forms/combobox/Combobox.ts
Comment thread scripts/sync-component-exports.mjs Outdated
SharonStrats and others added 2 commits May 7, 2026 19:25
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 41 out of 53 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

README.md:433

  • This prompt-history entry includes an absolute local filesystem path (/Users/...), which is not portable and can unintentionally leak developer machine details into published docs. Replace it with a repo-relative path (e.g., src/media/media-capture.ts) or omit the path entirely.
* GPT-5.4 Model: can you wire up the keyboard interactions and aria attributes for Select?

* GPT-5.4 Model: Take the code from /Users/sharon/2025Dev/solid-ui/src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.

Comment thread src/v2/components/forms/select/Select.ts
Comment thread src/v2/components/forms/select/Select.ts
Comment thread src/widgets/forms.js
Comment thread src/matrix/matrix.ts Outdated
Comment thread README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

4 participants