Update aura-backed secondary resources on UNIT_AURA#194
Open
KogasaPls wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the Secondary Resource Bar refresh when aura-backed custom resources change instead of waiting for a repaint. Visually, it eliminates the 100-250ms worst-case lag between the Cooldown Manager's tracker and the Secondary Resource Bar tracker if they're both enabled.
The resources covered here are:
When one of these auras was added, updated, or removed, the bar would not typically be updated until the fixed-rate UpdateDisplay() polling caused a repaint every 0.25s (or 0.1s with fast updates enabled). Subscribe to UNIT_AURA instead of waiting for the UpdateDisplay() timer so that the custom resource updates instantly.
Polling is still appropriate for resources that change very frequently (health/energy/mana). For simplicity and safety, the polling tick will still update the secondary resource bars even though they're event-driven now. A future optimization direction would be to reduce the work done via polling.
Context
This follows the direction of commit 6011ce1, which moved Tip of the Spear away from manual spellcast tracking and toward direct aura reads for accuracy.
It is deliberately narrower than #86. That PR looks at broader
OnUpdateoptimization; this one only adds the missing event trigger for custom resources that are already aura-backed.