Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
POST /api/v1/auth/login(명세 1번)family_idrecordLogin,getNickname(CLAUDE.md 표 반영)명세와 달라진 점
명세에 없거나 달랐던 부분을
s1-api-spec.md에 함께 반영함AUTH502_1문구를 노션과 같은 "다시 시도해주세요."로 통일refreshToken,Path=/api/v1/auth,SameSite기본Lax(AUTH_COOKIE_SAME_SITE로 변경 가능)provider가 없거나GOOGLE이 아니면AUTH400_1USER404_1테스트
전체
./gradlew build통과AUTH401_3,AUTH502_1, 탈퇴 회원USER404_1code·codeVerifier·redirectUri는COMMON400_1이고 구글을 부르지 않음provider오류AUTH400_1(NAVER, 소문자, null)toString에 토큰 미노출확인 체크리스트
./gradlew build통과리뷰어에게
AUTH200_2는 명세대로 코드 하나에 문구가 2개입니다.ResultCodeRegistry가 중복 코드를 막아서 두 번째 문구만 컨트롤러에서 넣었습니다. 화면은isCompletedSignUp으로 구분해야 합니다.