Skip to content

Replaces inline for loops with proper runtime loops. #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucasSantos91 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replaces inline for loops with proper runtime loops. #241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82109c6
Replaces inline for loops with proper runtime loops.
LucasSantos91 Apr 20, 2026
a4ae68c
Makes wrapper an extern struct
LucasSantos91 Apr 20, 2026
7cf69d8
Merge branch 'Snektron:master' into optimal_load
LucasSantos91 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/vulkan/render.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ const Renderer = struct {

fn renderDispatchTable(self: *Self, dispatch_type: CommandDispatchType) !void {
try self.writer.print(
"pub const {s}Dispatch = struct {{\n",
"pub const {s}Dispatch = extern struct {{\n",
.{dispatch_type.name()},
);

Expand Down Expand Up @@ -1516,7 +1516,7 @@ const Renderer = struct {
try self.writer.print(
\\pub const {0s}Wrapper = {0s}WrapperWithCustomDispatch({0s}Dispatch);
\\pub fn {0s}WrapperWithCustomDispatch(DispatchType: type) type {{
\\ return struct {{
\\ return extern struct {{
\\ const Self = @This();
\\ pub const Dispatch = DispatchType;
\\
Expand Down Expand Up @@ -1569,11 +1569,16 @@ const Renderer = struct {
try self.writer.print(
\\pub fn load({[params]s}) Self {{
\\ var self: Self = .{{ .dispatch = .{{}} }};
\\ inline for (std.meta.fields(Dispatch)) |field| {{
\\ if (loader({[first_arg]s}, field.name.ptr)) |cmd_ptr| {{
\\ @field(self.dispatch, field.name) = @ptrCast(cmd_ptr);
\\ }}
\\ }}
\\ const names = comptime blk:{{
\\ const fields = @typeInfo(Dispatch).@"struct".fields;
\\ var names: [fields.len][*:0]const u8 = undefined;
\\ for (&names, fields) |*d, f| d.* = f.name.ptr;
\\ break :blk names;
\\ }};
\\ const self_as_ptr: [*]?*const anyopaque = @ptrCast(&self.dispatch);
\\ for (self_as_ptr[0..names.len], names) |*ptr, name| {{
\\ ptr.* = loader({[first_arg]s}, name);
\\ }}
\\ return self;
\\}}
, .{ .params = params, .first_arg = loader_first_arg });
Expand Down
Loading