SEP Phase 3 (engine): thread ui_capabilities through handshake#27
Merged
Conversation
ExtensionHost::load now forwards a ui_capabilities list into each extension's initialize params so a host declares which ui/request kinds its frontend can render. The ext→host ui/request seam and headless -32001 NoUI default landed in Phase 2; this closes the loop so extensions can gate their UI (hasUI). Adds a SEP_ECHO_UI round-trip mode to the reference peer + sep_ui_path integration test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b84a4b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Phase 2 landed the ext→host
ui/requestseam (HostDelegate::ui_request) with a headless-32001 NoUIdefault, butExtensionHost::loadhardcodedui_capabilities: Vec::new()— so a host could never tell an extension whichui/requestkinds its frontend can actually render. Extensions had no basis for ahasUIgate.Solution
ExtensionHost::load/load_onetake aui_capabilities: Vec<String>and forward it into each extension'sinitializeparams. The engine still ships headless (empty caps); smooth-code / the daemon supply the real set plus aHostDelegatethat renders dialogs.Verification
SEP_ECHO_UImode on the referencesep-echo-peerround-trips aui/requestconfirm from inside atool/execute, echoing the negotiated caps into the prompt.sep_ui_pathintegration test: a confirming host answers the round-trip AND the prompt proves caps were threaded; a headless host answers-32001 NoUI.cargo test(sep_ui_path, sep_tool_path, sep_agent_integration) green; new code clippy-clean.Part of the SEP epic (plan greedy-yawning-petal). Consumed by the smooth-code Phase 3 host +
th extCLI in the smooth repo.🤖 Generated with Claude Code