Implement Dialog#532
Merged
Merged
Conversation
wash2
requested changes
Jul 13, 2026
wash2
left a comment
wash2
left a comment
Member
There was a problem hiding this comment.
This looks pretty good, but could you fix the clippy errors introduced by the PR?
Contributor
Author
|
@wash2 thanks for the review. I will fix them |
Murmele
commented
Jul 14, 2026
wash2
approved these changes
Jul 14, 2026
Contributor
Author
|
@wash2 are you planning also for a release soon? Because then it could be also integrated into winit |
Member
|
Sure, I can do a release soon :) |
Contributor
Author
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the dialog extension from wayland. I am fairly new to the codebase, so just let me know if I am doing something wrong
I reused as much as possible from the Window so we don't duplicate the codebase of the window