chore(tooling): remove the Dagger engine and its runner scale set - #2073
Merged
Merged
Conversation
Contributor
🔍 Rendered manifest diff — this PR vs
|
Closes #1595. Dagger's CI usage was already removed in #1810 (ADR-0039); this removes what was left: the in-cluster dagger-engine deployment, the dedicated dagger-gha-runner-scale-set HelmRelease, and every reference to them in Polaris exemptions, network policies, the render-bundle overrides, the secrets baseline, the CI-pipeline diagram and its export, and the docs site. Both components were already disabled (commented out of tooling/aws-0/kustomization.yaml), so merging this deletes nothing from a live cluster beyond what Flux prune already excludes from the rendered bundle validated in CI — the 10 resources they still contributed to that validation-only render (ConfigMap, Service, Deployment, PodDisruptionBudget, CiliumNetworkPolicy, HelmRelease, ServiceAccount, Role, RoleBinding, AutoscalingRunnerSet) drop out of it.
Removing dagger-engine and its runner scale set (3c08b250) dropped the rendered bundle's controller count from 156 to the now-measured 160. AGENTS.md and its scripts/AGENTS.md counterpart still said 156; validation.md already said 160. Point both at the same number.
Smana
force-pushed
the
chore/remove-dagger-engine
branch
from
September 21, 2026 21:14
055245f to
942e823
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last of Dagger: the in-cluster engine and its GitHub Actions runner scale set. Dagger's CI step was already removed in #1810, and ADR-0039 (on #2061) records why. Closes #1595.
Merging this deletes both from the cluster through Flux prune. Both components were already commented out of
tooling/aws-0/kustomization.yaml, and every workflow usesruns-on: ubuntu-latest, so nothing depends on them.What goes
tooling/base/dagger-engine/(6 files) andtooling/base/gha-runners/dagger-scale-set-helmrelease.yaml, plus their references:gha-runnerskustomization and its network policy;tooling/aws-0/kustomization.yaml;.polaris.yamlexemptions;CHART_RENDER_OVERRIDESentry inscripts/flux-schema/render-bundle.py, keyed on the deleted HelmRelease.ci-workflows.md,validation.md,further-reading.md,repo-tree.yaml,stack.yaml, and the orphaneddagger.svglogo with its license row.docs/architecture/ci-pipeline.drawio: the "Dagger → daggerverse/pre-commit-tf" box, re-exported with the pinned drawio 30.3.6. Every other export came back byte-identical.Kept, as history: ADR-0005, and the three
ci.yamlcomments explaining why Dagger left.One unrelated fix rides along. The rendered-controller count quoted in
validation.md, rootAGENTS.mdandscripts/AGENTS.mdhad drifted: it said 156, and the measured count is 160 (110 Deployment, 25 Job, 10 StatefulSet, 8 DaemonSet, 7 CronJob). All three now agree.Installation removal, not a decision, so no ADR (ADR-0039 already covers Dagger). The old SPEC-009 branch
chore/remove-dagger(2026-07-15, never opened) is superseded by this PR.Evidence
Run on this branch, rebased on
42f567e8:./scripts/validate-manifests.shexits 0:Summary: 2105 resources found in 276 files - Valid: 2105, Invalid: 0, and "All gates passed". Before this change it was 2115; the drop is exactly the 10 Dagger resources.validate-links.sh,verify-doc-paths.shandvalidate-doc-claims.sh(30/30) exit 0.git grep -i dagger, outside the dated archive, returns 4 hits, all history..secrets.baselineloses only the deleted file's entry.