Skip to content

fix(phase1): harden editor and compiler workflows - #3

Merged
SloppyBobbert merged 2 commits into
mainfrom
omos/phase1-correctness-pr
Aug 27, 2026
Merged

fix(phase1): harden editor and compiler workflows#3
SloppyBobbert merged 2 commits into
mainfrom
omos/phase1-correctness-pr

Conversation

@SloppyBobbert

Copy link
Copy Markdown
Owner

Summary

  • preserve draft, formula, save, and compile ownership across reloads and overlapping async operations
  • separate Generate from Compile while retaining the last successful PDF and exact compile snapshot
  • persist template selections, enforce staff/owner boundaries, and validate compiler requests with limits, throttling, timeouts, and generic diagnostics
  • document Phase 1 evidence and the remaining infrastructure work

Verification

  • frontend: 100 tests passed
  • frontend: ESLint passed
  • frontend: Vite production build passed
  • backend: 128 tests passed with 96% coverage
  • Django system check passed
  • migration dry-run reported no changes
  • changed Python files compiled successfully
  • git diff --check passed

Deferred infrastructure

  • compile throttles still require a shared cache and trusted client-IP handling for global multi-worker enforcement
  • full compiler process/container, filesystem, network, CPU, memory, process-count, and output isolation remains open
  • anonymous compilation should not be treated as production-safe until that infrastructure is complete

Copilot AI lite review requested due to automatic review settings August 27, 2026 03:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@SloppyBobbert
SloppyBobbert merged commit ab7f753 into main Aug 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants