Fix Matrix-Game-3 Ulysses attention dispatch - #85
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using the keyword accepted by
wan.modules.attention.attention.so a renamed or misspelled keyword fails before multi-GPU inference.
Fixes #80
Why
The distributed path passed
fa_version=...to a function whose parameter isversion. Every run with--ulysses_size > 1therefore raisedTypeErrorinthe first attention block, before any backend selection or model computation.
The single-word forwarding fix leaves attention math and all non-Ulysses paths
unchanged.
Validation