Skip to content

upload: Include relative dependencies when topics are specified#274

Open
Abhishek21g wants to merge 1 commit into
Skydio:mainfrom
Abhishek21g:fix/upload-topic-dependencies-265
Open

upload: Include relative dependencies when topics are specified#274
Abhishek21g wants to merge 1 commit into
Skydio:mainfrom
Abhishek21g:fix/upload-topic-dependencies-265

Conversation

@Abhishek21g

Copy link
Copy Markdown

Summary

Fixes #265.

revup upload child now also uploads child's relative dependency chain (e.g. base) instead of ignoring dependencies and risking conflicts.

Verification

python3 -m pip install -e '.[dev]'
python3 -m pytest tests/test_upload.py::TestUploadLimitTopics::test_limit_topics_pulls_in_relative_dependencies -q

When the user passes explicit topic names on the command line, expand the
upload set to include the full relative dependency chain.

Fixes Skydio#265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[upload] specifying topics should also pull in relative dependencies

1 participant