Fix Node DEP0152 GC deprecation warning in SystemMetricsCollector - #20
Merged
mvogttech merged 1 commit intoAug 14, 2026
Merged
Conversation
Read GC kind from entry.detail.kind with a fallback for older Node, and use numeric perf_hooks constants so gcPauseTime accounting is correct on Node 24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeprecationWarning: Custom PerformanceEntry accessors are deprecated(DEP0152) in GC monitoring by readingentry.detail.kindinstead of the deprecatedentry.kindaccessor.perf_hooksconstants (NODE_PERFORMANCE_GC_MAJOR,NODE_PERFORMANCE_GC_MINOR,NODE_PERFORMANCE_GC_INCREMENTAL) instead of string labels like'major'/'minor'.1.1.1.Test plan
npm test— all 1141 unit tests pass--trace-deprecation --expose-gc: DEP0152 warning no longer appears after fix_getGcKindand_processGcEntry