Skip to content

Add pathname helper to proxy base. Update LocaleProxy and MultisiteProxy to use helper. - #645

Open
mjarosch wants to merge 1 commit into
Sitecore:devfrom
mjarosch:feature/proxy-pathname-helper
Open

mjarosch wants to merge 1 commit into
Sitecore:devfrom
mjarosch:feature/proxy-pathname-helper

Conversation

@mjarosch

@mjarosch mjarosch commented Oct 6, 2026 •

Copy link
Copy Markdown

Description / Motivation

This is a fix for issue 639. Update ProxyBase to include a getPathname helper that checks the REWRITE_HEADER_NAME first and falls back to the nextUrl.pathname if it is empty. Updated the LocaleProxy and MultisiteProxy to use this helper.

This is the logic that already existed in the MultisiteProxy. I have pulled it into the base to use as a shared method.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)
    Updated the ProxyBase unit tests to include logic for the helper.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@changeset-bot

changeset-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4796660

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants