Repository navigation
[nextjs][pages] Soft-fail scClient requests when browser context ID is missing - #644
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c59f354 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Package Size and Test Coverage Report
|
illiakovalenko
approved these changes
Oct 6, 2026
illiakovalenko
left a comment
illiakovalenko
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me 👍
Please, see a couple of comments below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Pages router apps can fail a render when a client context ID is missing. This can mainly be observed in rendering
SitecoreStylescomponent in CSDK Layout, that calls scClient.getHeadLinks(). It can also occur whenscClient.getPageand other methods are called in shared server/browser context.The current implementation of SitecoreClient + GraphQL client is tacitly accepting a situation when context ID is absent during initialization in browser context, despite the browser scClient instance being not useful. This leads to issues and exceptions arising later.
The proposed fix is adding a couple of guards to soft-land a contextId-less scClient:
Testing Details
Types of changes