Contain type instability in G-1 outage-driven typeof dispatches

src/services_models/reserves.jl

@@ -491,6 +491,8 @@ function add_constraints!(
     reserve_response_time = PSY.get_time_frame(service)
     jump_model = get_jump_model(container)
     for d in contributing_devices
+        # PERF: type unstable. _add_reserve_power_constraint_over_time! function barrier
+        # limits the impact, but a systematic fix would be better.
         component_type = typeof(d)
         name = PSY.get_name(d)
         varstatus = get_variable(container, OnVariable, component_type)
@@ -503,12 +505,27 @@ function add_constraints!(
         else
             reserve_limit = 0.0
         end
-        for t in time_steps
-            cons[name, t] = JuMP.@constraint(
-                jump_model,
-                var_r[name, t] <= (1 - varstatus[name, t]) * reserve_limit
-            )
-        end
+        _add_reserve_power_constraint_over_time!(
+            cons, jump_model, var_r, varstatus, name, reserve_limit, time_steps,
+        )
+    end
+    return
+end
+
+function _add_reserve_power_constraint_over_time!(
+    cons,
+    jump_model,
+    var_r,
+    varstatus,
+    name::String,
+    reserve_limit,
+    time_steps,
+)
+    for t in time_steps
+        cons[name, t] = JuMP.@constraint(
+            jump_model,
+            var_r[name, t] <= (1 - varstatus[name, t]) * reserve_limit
+        )
     end
     return
 end