fix: widen event parameter contingency bound to SupplementalAttribute - #146
Draft
m-bossart wants to merge 1 commit into
Draft
fix: widen event parameter contingency bound to SupplementalAttribute#146m-bossart wants to merge 1 commit into
m-bossart wants to merge 1 commit into
Conversation
PSY.Contingency subtypes IS.SupplementalAttribute, not IS.InfrastructureSystemsComponent, so the event add_param_container! overload and EventParametersAttributes MethodError on real contingency types. Widen the contingency type parameter's bound and drop the unused affected_devices field, which had no readers.
Contributor
|
Performance Results This branch |
luke-kiernan
reviewed
Aug 3, 2026
| T <: IS.SupplementalAttribute, | ||
| U <: ParameterType, | ||
| } <: ParameterAttributes | ||
| affected_devices::Vector{T} |
Collaborator
There was a problem hiding this comment.
You're removing the affected_devices field. Looking in IOM, POM, and PSI, I don't see anywhere that field is used, but then that makes me wonder why it's here at all.
edit: oh, I see you noticed the same thing. I guess I'd like confirmation from Jose that we don't need that field before removing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSY.Contingency subtypes IS.SupplementalAttribute, not IS.InfrastructureSystemsComponent, so the event add_param_container! overload and EventParametersAttributes MethodError on real contingency types. Widen the contingency type parameter's bound and drop the unused affected_devices field, which had no readers.