test unit invariance of objective function coefficient - #142
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression tests to ensure objective-function coefficients derived from linear and quadratic cost curves are invariant to the unit system used to express the same underlying physical costs (natural units vs system-base vs device-base), strengthening correctness around unit conversions in objective construction.
Changes:
- Add unit-system invariance test coverage for
CostCurve{LinearCurve}objective coefficients. - Add unit-system invariance test coverage for
CostCurve{QuadraticCurve}linear and quadratic objective coefficients.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_linear_curve.jl | Adds a testset verifying linear-cost objective coefficients match across NATURAL_UNITS, SYSTEM_BASE, and DEVICE_BASE representations of the same physical rate. |
| test/test_quadratic_curve.jl | Adds a testset verifying both linear and quadratic objective coefficients match across NATURAL_UNITS, SYSTEM_BASE, and DEVICE_BASE representations of the same physical quadratic cost. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Performance Results This branch |
acostarelli
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says: put the same physical data in different unit systems and check that we get the same objective function coefficient in each case.