Repository navigation
Item, achievement, character and auction links are now Discord buttons, not embed text - #9
Merged
Merged
Conversation
… badge announcements put their links in buttons instead of embed text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts every link-only field/line a slash-command reply, DM, or announcement posts into Discord link buttons under the embed, instead of markdown links inside the embed text.
Commands changed
/item[Item page](...) • [Wowhead](...)/itemselect menu (other matches) carries the same two buttons and repoints them at the newly shown item when you pick another match. Chat item-link unfurls get the same button view./achievement[View on site](...)(title already linked viaembed.url)https://www.wowhead.com/forever/achievement={id}, matching what the website itself links to) buttons is attached, for both the digit-id and name-search paths. The select menu (other matches) repoints both buttons when you pick another match./who[View on Armory](...)[View on the site](...)embed.url); a view with a single View on the site button is attached to the DM./price's embed was left as-is — it already usedembed.url(a native title hyperlink), not a markdown field.[View the Hall of Heroes](...)Left as inline prose (a button would read worse and lose the sentence): the sign-in disclosure's "account page" link in
gate_messages.py.Shared helper:
link_button/link_viewadded tolib/embeds.py(already imported everywhere these replies are built) instead of duplicating button construction per plugin.Every touched view has at most 3 components (select + 2 link buttons, or up to 2 link buttons alone) in one row, well inside Discord's per-row/per-view limits.
Testing
make ci(ruff format/lint, pyrefly, pytest): all green, 1188 tests passed.