Skip to content

Item, achievement, character and auction links are now Discord buttons, not embed text - #9

Merged
JacobCoffee merged 1 commit into
mainfrom
fix/link-buttons
Nov 13, 2026
Merged

JacobCoffee merged 1 commit into
mainfrom
fix/link-buttons

Conversation

@JacobCoffee

Copy link
Copy Markdown
Contributor

Converts every link-only field/line a slash-command reply, DM, or announcement posts into Discord link buttons under the embed, instead of markdown links inside the embed text.

Commands changed

Command / message Before After
/item Embed had a "Links" field: [Item page](...) • [Wowhead](...) No link field; a view with Item page and Wowhead buttons is attached. The /item select menu (other matches) carries the same two buttons and repoints them at the newly shown item when you pick another match. Chat item-link unfurls get the same button view.
/achievement Embed had a "Site" field: [View on site](...) (title already linked via embed.url) No "Site" field; a view with Site and Wowhead (new https://www.wowhead.com/forever/achievement={id}, matching what the website itself links to) buttons is attached, for both the digit-id and name-search paths. The select menu (other matches) repoints both buttons when you pick another match.
/who Embed had an "Armory" field: [View on Armory](...) No "Armory" field; a view with a single View on Armory button is attached.
Auction price-drop DM Embed description was [View on the site](...) Description link removed (the embed's title already links there via embed.url); a view with a single View on the site button is attached to the DM. /price's embed was left as-is — it already used embed.url (a native title hyperlink), not a markdown field.
Badge announcement Embed had a "Hall of Heroes" field: [View the Hall of Heroes](...) No "Hall of Heroes" field; a view with a single Hall of Heroes button is attached to the channel post.

Left as inline prose (a button would read worse and lose the sentence): the sign-in disclosure's "account page" link in gate_messages.py.

Shared helper: link_button/link_view added to lib/embeds.py (already imported everywhere these replies are built) instead of duplicating button construction per plugin.

Every touched view has at most 3 components (select + 2 link buttons, or up to 2 link buttons alone) in one row, well inside Discord's per-row/per-view limits.

Testing

  • Updated unit tests for every converted command/message to assert button labels/URLs instead of markdown link text, including the select-menu views repointing their buttons on swap.
  • make ci (ruff format/lint, pyrefly, pytest): all green, 1188 tests passed.

… badge announcements put their links in buttons instead of embed text
@JacobCoffee
JacobCoffee merged commit 52a52ff into main Nov 13, 2026
7 checks passed
@JacobCoffee
JacobCoffee deleted the fix/link-buttons branch November 14, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant