Repository navigation
feat: /achievement, /recipe and /compare look up achievements, recipes with their guild crafters, and two characters side by side - #5
Merged
Conversation
…, description and category
… crafters who know it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/achievement <name>looks up a WoW: Forever achievement (points, description, category, icon, site link). No name-search route exists on the site, so the cog flattens the category tree into a module-cached catalog (1h TTL, matching the site's own edge cache) and offers autocomplete + a select menu for other matches, mirroring/item's pattern./recipe <name>shows a recipe's profession, crafted item, reagents and guild crafters, reusing/crafter's bot-key crafters route to find the matching recipe's Battle.net id (no recipe name-search route exists either), then fetches full detail fromGET /api/recipes/{id}. Falls back to a crafters-only view if Battle.net was unreachable when the guild's crafter data last synced./compare <character1> <character2>is/whofor two characters side by side: level/class/PvP per side, item level with the lead highlighted, and a per-slot gear comparison table in a code block. Reuses/who's autocomplete and slug parsing; bothget_charactercalls run concurrently.AchievementSchema/AchievementCategoryTree/AchievementCategorySchema/RecipeDetailetc. directly from the pinnedsidequest-commoncommit (these schemas are already in the pin, confirmed identical to the website's currentHEAD), plus three newapi_client.pymethods for achievements and one for recipes.Testing
make ci(ruff format/lint, pyrefly, pytest): all green, 1162 tests passed.api_clientmethods against the real public site (https://sidequest-guild.com):/api/achievements/{id}→ builtbuild_achievement_embed→ rendered viaembed.to_dict()./api/recipes/{id}→ builtbuild_recipe_embed(showed a real guild crafter, "Nox Zul — skill 119")./api/characters/{slug}for a roster pair → builtbuild_compare_embed(real item-level/gear diff table).Docs