Repository navigation
feat: /quest and /beast look up quests with their chain and tameable beasts - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sidequest-common/sidequest-apito website commit59a86f9(quests + beasts reference endpoints).SideQuestAPI.search_quests/get_questandsearch_beasts/get_beast/list_beast_families./quest <name>(autocomplete viaGET /api/quests/search, numeric id also accepted): shows area/category/type, level range, rewards (XP, money, items, reputation), its place in the quest chain (earlier quests → this quest → follow-ups, truncated cleanly), one-of-grouped requirements, and quests it excludes. Link buttons to the site page and Wowhead. Offers other matches in a select menu when the search returns several, same pattern as/item//achievement./beast <name> [family](autocomplete viaGET /api/beasts, with an optionalfamilyparameter autocompleted fromGET /api/beasts/families; numeric creature id also accepted): shows the beast's family, a tameable-by-hunters note, and its portrait image. Link buttons to the (single, non-deep-linkable) Beasts page and Wowhead. The website builds its whole beast catalog on the first/api/beastscall per process (~800 Battle.net media lookups, 10-20s), so both autocomplete callbacks apply their own short timeout and fall back to no suggestions instead of stalling past Discord's ~3s autocomplete budget.Testing
make ci(ruff, pyrefly, pytest) exits 0; 1271 tests passing, including the slow-catalog autocomplete-timeout cases for/beast.