Add GGUF audio and microphone transcription support#88
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR refactors GGUF filename handling in ModelStoreRepository to improve model file filtering, quantization parsing, and model ID generation, and adds unit tests to validate the new helper logic.
Changes:
- Added centralized GGUF helpers (
isSupportedGgufFile,stripGgufSuffix,extractQuantType) and updated GGUF listing logic to use them. - Bumped model store cache version to invalidate stale cached listings after filtering/parsing changes.
- Added
ModelStoreRepositoryTestto cover GGUF extension handling, projection artifact filtering, suffix stripping, and quant parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/java/com/dark/tool_neuron/repo/ModelStoreRepository.kt | Introduces helper methods for GGUF filtering/quant parsing, updates model listing logic, bumps cache version. |
| app/src/test/java/com/dark/tool_neuron/repo/ModelStoreRepositoryTest.kt | Adds unit tests for the new GGUF helper behaviors and edge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @Godzilla675 Till now we don't support Audio GGUF |
|
Hmm ok ill see another way to fix the issue. |
|
@Siddhesh2377 can I implement gguf audio model support? |
|
Yes @Godzilla675 |
|
Ok |
|
@Siddhesh2377 I noticed that there is no mic transcription-based support in the app while working on the audio gguf support. shall I add it while I'm working? |
Godzilla675
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55262cc964
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hey @Godzilla675 Yes u can add it for sure ! |
- add RECORD_AUDIO permission and a MediaRecorder-based chat recorder - keep file import as a fallback while staging recorded clips before send - route microphone audio through the existing GGUF transcription path Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Godzilla675
changed the title
|
@Siddhesh2377 I finished the implementation if you want to review |
|
@Siddhesh2377 do I fix the merge conflicts or do I wait a bit until you finish the changes you are currently doing? |
|
Hey @Godzilla675 |
|
@Siddhesh2377 ok, where is the discord though? can you send me the link? |
|
Yes, make a working apk release on your fork and send me the link on discord |
|
ok. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore GGUF projector/audio integration after the re-write merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Recognize mmjproj as a projector marker alongside mmproj, vision-adapter, projector - Score mmjproj candidates in sidecar auto-download selection - Broaden user-facing projector readiness message to mmproj/mmjproj - Add unit tests for mmjproj filtering and case-insensitive detection
|
@Siddhesh2377 i added mmproj support. you can download the apk here https://github.com/Godzilla675/ToolNeuron/releases/tag/toolneuron-fix-whisper-test-apk |
|
Hey @Godzilla675 — thanks a lot for putting this together. Closing this one because the v3 rewrite (#105) just landed and it reorganises the engine layer end-to-end, so this branch can't be merged cleanly anymore. The new GGUF engine in v3 already includes whisper / mic transcription support through sherpa-onnx, so the feature itself isn't lost. Really appreciate the contribution — if you want to port any specific tweak onto the new base, happy to look at a fresh PR against |
Summary
gguf_libAARDependencies
Validation
./gradlew --no-daemon --no-configuration-cache --max-workers=1 -Dorg.gradle.jvmargs='-Xmx2g -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8' -Pksp.incremental=false :app:testDebugUnitTest --tests com.dark.tool_neuron.repo.ModelStoreRepositoryTest./gradlew --no-daemon --no-configuration-cache --max-workers=1 -Dorg.gradle.jvmargs='-Xmx2g -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8' -Pksp.incremental=false :app:assembleDebug