Conversation
Assisted-by: Codex: gpt-5.6 Signed-off-by: Dylan Steele <dylansteele57@gmail.com>
Assisted-by: Codex: gpt-5.6 Signed-off-by: Dylan Steele <dylansteele57@gmail.com>
Assisted-by: Codex: gpt-5.6 Signed-off-by: Dylan Steele <dylansteele57@gmail.com>
dills122
marked this pull request as ready for review
August 3, 2026 22:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
FD_CLOEXEC, identity, unlink state, caller close/reuse, and context-owned cleanupNo public API changed. No path authority was added.
Why
The retained governed measurement had zero function and line coverage in both
port.rsandprocess_tx.rs. Exercising those boundaries exposed two local lifecycle defects: a shutdown racing a queued backpressured descriptor could repeatedly re-pop it, and a shut-down port remained logically active after its workers were joined.Coverage
port.rs, functionsport.rs, linesprocess_tx.rs, functionsprocess_tx.rs, linesRemaining measured gaps are 2 functions/26 lines in
port.rsand 0 functions/14 lines inprocess_tx.rs.governance/capsule-v1.19.4/coverage-followup.jsonretains the exact measurement.Governed verification
blkcorpus: 53 passed, including the 2 existing raw-FD testsblkraw-FD integration target: compiled with 0 gated tests; theblkroute still ran both testsGuestMemory::try_accessdeprecation allowanceThe exact five retained patch files and aggregate patch-set identity
d19fd0ff159c699acccda2621519de45a09408bf3847b418ac34e02b79e805d5are unchanged. Reconstruction starts at upstream728df8125077d0db44265f6e997c72b81b65c015and matches governed merge4ea8d1de861ed1c0636fc800b6da8fb71a086aa5.Default-init boundary and limitations
The governed wrapper is an offline library-only gate and passes completely. The standalone default-init probe remains fail-closed on this macOS environment because it has no pre-provisioned exact Linux sysroot; it did not download or bootstrap one. The existing upstream macOS cross-compilation workflow provisions that environment and runs
makewith the default Linux init blob, without guest execution, and must independently pass as the PR's build evidence for that route.No VM or guest was created or run. This is not VMM transport, installed-product, backend/profile admission, Capsule product wiring, release, signing, firmware, kernel, Supervisor, or deployment evidence. Independent human and CODEOWNER review remain required, so this PR is draft.