Repository navigation
Remove the benchmark profile and BenchmarkTest - #1
Closed
Shraddhameduri wants to merge 7 commits into
Closed
Shraddhameduri wants to merge 7 commits into
Shraddhameduri wants to merge 7 commits into
Conversation
Removed outdated benchmarks instructions from README.
…re/pom.xml Removed the maven-surefire-plugin block that only excluded BenchmarkTest, and removed the benchmark Maven profile whose -XX:MaxPermSize argLine breaks on modern JDKs.
Removed exclusion for BenchmarkTest.java in surefire plugin configuration.
Removed benchmark comments for encoding performance.
Owner
Author
|
Closing this PR — it was opened against my fork's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OWASP#121
The
benchmarkMaven profile is broken on modern JDKs (its-XX:MaxPermSize=256margLine is a hard JVM startup error on JDK 9+) and theBenchmarkTestit ran has been deleted, so the profile, its surefire excludes, and the stale benchmark comments/docs are dead weight.Changes
core/pom.xml: removed thebenchmarkprofile and the surefire plugin block that only existed to excludeBenchmarkTestpom.xml: removed theBenchmarkTestsurefire excludecore/src/test/java/org/owasp/encoder/BenchmarkTest.javaand its two data files (benchmark-data-1.txt,benchmark-data-2.txt)HTMLEncoder.java: removed stale benchmark timing comments and theBenchmarkTestreferenceREADME.md: removed the benchmark-profile docs sectionVerified
grep -ri benchmarkreturns nothing across pom files, sources, and README; both POMs still parse as well-formed XML and the failsafeosgi-compatibilityexecution is untouched.