Use typed override for spoom bump#966
Open
Morriar wants to merge 1 commit into
Open
Conversation
Run Sorbet with a temporary --typed-override file when checking bump candidates instead of rewriting sigils before typechecking. Reject projects that already configure --typed-override to avoid conflicting overrides, and assert temporary override files are cleaned up in bump tests.
amomchilov
reviewed
Jun 29, 2026
| Sorbet::Sigils.change_sigil_in_files(files, from_strictness) | ||
| #: (Spoom::Context context, Array[String] files, String strictness) -> String | ||
| def write_typed_override_file(context, files, strictness) | ||
| path = ".spoom-typed-override-#{Process.pid}-#{SecureRandom.hex(8)}.yaml" |
Contributor
There was a problem hiding this comment.
Can't we just use Tempfile.new(['spoom-typed-override', '.yml'])?
Then there's no need to have it hidden with the prefixed .
juharris
reviewed
Jul 2, 2026
| relative_path = file.delete_prefix("#{context.absolute_path}/") | ||
| "./#{relative_path}" | ||
| end | ||
| context.write!(path, YAML.dump({ strictness => relative_paths })) |
There was a problem hiding this comment.
Do we delete the file when we're done?
Is that was using context helps with?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Sorbet with a temporary
--typed-overridefile when checking bump candidates instead of rewriting sigils before type checking.