Was this vibe coded? Where are the unit tests?

[darrynten]

Feels like a massive downgrade from the previous package which seems to be abandoned

[byrichardpowell]

Hey @darrynten 👋

No, the package was not vibe coded. It's been reviewed by multiple people, at multiple levels, from multiple lenses.

The package is thoroughly tested with ~350 unit tests. We didn't publish the tests because they are shared with the Python package. If the lack of published unit tests is an issue, I can take that feedback back to the team, but please be assured the package is well tested.

I would argue that the package is a massive upgrade from the previous package:

• It supports 14 platform features vs ~6 (depending on how you slice it).
• It steers users away from complexity that is no longer needed due to platform simplication.
• Package design and supporting README is such that agents can get up to speed very quickly.
• Feedback from early adopters is very positive.

If you've tried the package and have any feedback, I'd love to bring that back to the team.

Thanks for building on Shopify 👍

[darrynten]

Thank you for clarifying. I'm trying to migrate existing stores from non-expiring offline tokens to expiring offline tokens and am not having a good time.

I've integrated this package into my framework and while some of it works very well I am still not able to figure out how we're supposed to follow the expiring offline token migration guide published by Shopify, and time is running out quickly. BFCM is fast approaching and we'd like to have existing installs migrated before then.

I'm trying to follow the suggested principal of route-by-route migration, so am using this package alongside the previous package, but as long as this PR from the old package remains open I'm a bit stuck and getting more and more frustrated every day. I would ideally like to proceed without having to maintain my own fork of the legacy repo.

It would be great if maintainers could review that open PR and merge it in to the previous package so that we can complete our work and start to migrate shops to expiring offline tokens in existing apps ASAP.

The open PR Shopify/shopify-api-php#467 supports token exchange using the urn:ietf:params:oauth:token-type:id_token subject and expands the Session class in a way that it can be integrated with this packages TokenExchange result.

Once that is merged in we will be able to extend the legacy package further to support the documented migration flow of exchanging the non-expiring offline token with the new expiring offline tokens, using the one-time exchange with the urn:shopify:params:oauth:token-type:offline-access-token subject.

It would be great if this new package could officially support something like a \Shopify\App\Internal\Exchange\NonExpiringTokenMigration class to help those of us with existing apps move existing installs across smoothly, as well as docs that are more human developer focused rather than agent focused.

I do appreciate the simplification of the platform and package, however, until there is support for legacy features like the Rest API and a robust Webook Registry the reality is that existing apps using these "outdated" features are going to be forced to run both packages side-by-side until they've been provided with and migrated to newer alternatives, so it would be nice if the existing legacy package could continue to receive a little TLC during this transitory period, however long that may be.