Repository navigation
Keep test socket descriptors under one owner - #238
Merged
Merged
Conversation
The serialization tests reload live socket descriptors in the same process. The original and restored Ruby objects can both close each descriptor. Garbage collection can close a socket that another object still uses. This can cause Errno::EBADF in CI. The socket cast tests also create multiple owners for one descriptor. Duplicate the descriptors for child round trips, transfer ownership for the worker round trip, and make socket cast views non-owning. Run garbage collection between child round trips to exercise the socket lifetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The serialization tests reopen live socket descriptors in the same Ruby process. The original and restored objects can both own each descriptor. Garbage collection can close a descriptor that another object still uses.
The Ruby 3.4 job on master failed with
Errno::EBADFinTestChildren#test_dump_load.The socket cast tests also create multiple owners for the same descriptor. A later collection can close a descriptor that another test reuses.
Fix
These changes affect tests only. A real monitor restart replaces the process image before it restores the descriptors.
Verification
IO.for_fdownership option.