Fix CSP nonce hydration mismatch in ShopifyScripts - #3857
Closed
AboodFares wants to merge 1 commit into
Closed
Conversation
Browsers hide a parsed script's nonce content attribute (exposing nonce="" while the real value stays on the .nonce property), which React reported as an attribute mismatch on the external generated script on every full page load when a CSP nonce was used. Suppress this known, benign diff for generated script tags when a nonce is supplied. Inline scripts were already covered via their innerHTML branch. Fixes Shopify#3855 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Hi 👋 Sorry this was already fixed in preview before we brought the development to this repository! Thanks in any case for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsers hide a parsed script's nonce content attribute (exposing nonce="" while the real value stays on the .nonce property), which React reported as an attribute mismatch on the external generated script on every full page load when a CSP nonce was used. Suppress this known, benign diff for generated script tags when a nonce is supplied. Inline scripts were already covered via their innerHTML branch.
Fixes #3855
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist