fix: mark default session cookie as Secure in production#3806
Open
andguy95 wants to merge 1 commit into
Open
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Strengthen the default security of session cookie configuration and post-login redirect handling for secure cookie attributes and redirect validation.
WHAT is this pull request doing?
Session cookie hardening (
templates/skeleton/+ 10 example files):secure: process.env.NODE_ENV === 'production'to allcreateCookieSessionStoragecookie configsRedirect validation (
packages/hydrogen/src/customer/customer.ts):getRedirectUrl(which accepted any same-origin URL regardless of protocol) withgetSafeCustomerAccountRedirectPath— enforces HTTPS protocol, same-origin check, and normalizes output to a relative pathgetRedirectPathFromSearchParamsto extract and validatereturn_to/redirectquery paramslogin()(when the redirect path is stored) andauthorize()(when it's read back from the session) — defense-in-depth against session tamperingwarnRedirectUrlRejected()that fires in development mode with the[h2:warn:customerAccount]prefix when a redirect URL is rejected/accountTests (
packages/hydrogen/src/customer/customer.test.ts):javascript:,data:,//evil.com, malformed URLs)mockSuccessfulTokenExchange()helper to reduce duplicationHOW to test your changes?
pnpm vitest run packages/hydrogen/src/customer/customer.test.ts— 103 pass, 0 failsessioncookie in DevTools → Application → Cookies —Secureflag should be off in dev,sessioncookie in DevTools → Application → Cookies —Secureflag should be on in production (pnpm build && NODE_ENV=production pnpm start)Post-merge steps
None required.
Checklist