[Tests] Refactor install-cloudflared tests to remove filesystem mocks#7507
[Tests] Refactor install-cloudflared tests to remove filesystem mocks#7507gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
Refactor `packages/plugin-cloudflare/src/install-cloudflared.test.ts` to use real filesystem in a temporary directory instead of mocking `fs`. This makes the tests more trustworthy and better aligned with the project's test quality standards. Key improvements: - Replaced `vi.spyOn(fsActions, ...)` with `inTemporaryDirectory` + real file operations. - Mocked `http.fetch` to return a real `Readable` stream to test the actual download/piping logic. - Improved test names to describe behavior. - Added assertions to verify file existence and content on disk. - Fixed linter warnings regarding `expect().resolves`. Verified with `pnpm test`, `pnpm lint`, and `pnpm type-check` in the affected package.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
What was improved
Refactored
packages/plugin-cloudflare/src/install-cloudflared.test.tsto use a real filesystem in a temporary directory instead of mockingfs. This makes the tests more reliable and verifies the actual file-writing behavior.Duplicate check
I ran
git log --grep="Jules" --grep="Tests" --pretty=format:"%h %s" -n 50and didn't find any recent PRs targeting this file.Closest PRs considered:
How to test your changes?
Run the tests for the affected package:
Also verified linting and type-checking:
PR created automatically by Jules for task 10097903198854477211 started by @gonzaloriestra