Skip to content

[Refactor] Consolidate command execution in system.ts#7506

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-system-exec-unification-14120344445568562033
Draft

[Refactor] Consolidate command execution in system.ts#7506
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-system-exec-unification-14120344445568562033

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

captureCommandWithExitCode and execCommand in packages/cli-kit/src/public/node/system.ts were manually duplicating the environment setup, directory handling, and error processing logic already present in their array-based counterparts, captureOutputWithExitCode and exec.

WHAT is this pull request doing?

Refactors captureCommandWithExitCode and execCommand to delegate to captureOutputWithExitCode and exec respectively. This centralizes the logic for:

  • Setting FORCE_COLOR based on shouldDisplayColors().
  • Handling the working directory (cwd).
  • Performing checkCommandSafety checks.
  • Configuring execa options like windowsHide.

How to test your changes?

Run any CLI command that uses these utilities, for example:
shopify app build

Duplicate check

Query: gh pr list --repo Shopify/cli --state all --limit 200 --search 'label:"Jules" "Refactor" in:title' --json number,title,state,url,body,files

Closest prior PRs:

  1. [Refactor] Optimize copyDirectoryContents with glob cwd (aa120fb): Targets fs.ts, while this PR targets system.ts.
  2. [Refactor] Use relativePath utility in copyDirectoryContents (9c19e7f): Also targets fs.ts.
  3. [Refactor] Remove redundant Knip ignoreDependencies entries (b794124): Targets package.json.

This PR is meaningfully different because it focuses on unifying the command execution logic in system.ts, which hasn't been touched by previous Refactor PRs.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

PR created automatically by Jules for task 14120344445568562033 started by @gonzaloriestra

Refactors `captureCommandWithExitCode` and `execCommand` to delegate to
`captureOutputWithExitCode` and `exec` respectively. This centralizes
the logic for environment setup, working directory handling, and
command safety checks, reducing code duplication and improving
consistency across execution utilities.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant