Fix custom tunnel URL precedence in Codespaces app dev#7488
Open
afurm wants to merge 1 commit intoShopify:mainfrom
Open
Fix custom tunnel URL precedence in Codespaces app dev#7488afurm wants to merge 1 commit intoShopify:mainfrom
afurm wants to merge 1 commit intoShopify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to #6235
When
shopify app devruns inside GitHub Codespaces,generateFrontendURLcurrently detects the Codespaces environment before checking--tunnel-url. That means an explicit custom tunnel URL is ignored and the CLI always builds a Codespaces forwarding URL instead.This blocks developers who need to bring their own tunnel in Codespaces, for example to avoid embedded app preview failures caused by GitHub/Codespaces framing or cookie behavior.
WHAT is this pull request doing?
--tunnel-urlprecedence before Codespaces and Gitpod auto URL detection.@shopify/app.How to test your changes?
Automated checks run locally:
Manual behavior to verify:
shopify app dev --tunnel-url="https://my-tunnel-provider.io:4242"In a Codespaces environment, the app dev frontend URL should use
https://my-tunnel-provider.iowith port4242, instead of replacing it with the Codespaces forwarding URL.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add