Updates development environment to ruby@3.4 with the latest dev/edition#520
Merged
Conversation
GoodForOneFare
approved these changes
Jul 29, 2025
These builds have proven to be flaky, requiring someone to baby-sit randomly cancelled builds. They were introduced (9684a03) as part of the Sorbet transition and mostly maintained, but don't serve a purpose.
donk-shopify
force-pushed
the
donk/maintenance/update-ci
branch
from
f2a633e to
8dbf656
Compare
This was referenced Jul 29, 2025
The result of `Hash::inspect` changes between 3.3 and 3.4. By rendering the inspected value in the test, we remove the potential for a test failure on mere formatting.
donk-shopify
force-pushed
the
donk/maintenance/update-ci
branch
from
8dbf656 to
91f995b
Compare
donk-shopify
changed the title
ruby@3.4 with the latest dev/edition
The backtrace `Location` instance's name property contains the full class name in versions >= 3.4. The intention of this code had been to infer the name from the _called method_. Splitting on `#` preserves this assumption.
donk-shopify
force-pushed
the
donk/maintenance/update-ci
branch
from
91f995b to
9a6483b
Compare
GoodForOneFare
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemfile.lock