Skip to content

Fix non-Mac OS gem install path handling - #67

Merged
OughtPuts merged 1 commit into
mainfrom
gira/fix-windows-single-abi-install
Oct 15, 2026
Merged

OughtPuts merged 1 commit into
mainfrom
gira/fix-windows-single-abi-install

Conversation

@girachawda

@girachawda girachawda commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR

Install selected gems directly from Ruby instead of piping gem paths through xargs.

Why

Rubydex's release workflow (https://github.com/Shopify/rubydex/actions/workflows/release.yml) exposed this while tophatting include-single-abi: true. That workflow runs cibuildgem's test_cross step on Windows, which selects the generated single-ABI gem and installs it. Passing gem paths directly as Ruby argv entries avoids Windows line-ending issues and shell/xargs splitting differences across platforms.

Tophat

  • Tophatted through Rubydex by temporarily pointing its release workflow at this cibuildgem branch and running https://github.com/Shopify/rubydex/actions/runs/38601998546. The Windows cross jobs that previously failed on malformed \r gem paths passed for Ruby 3.2, 3.3, 3.4, and 4.0.
  • Parsed .github/actions/cibuildgem/action.yml locally.
  • Verified the new system Gem.ruby, "-S", "gem", "install", *gems style install works locally.
  • Verified it handles a local gem path containing spaces, which is more robust than piping through xargs.

@girachawda girachawda changed the title Fix Windows gem install path handling Fix non-Mac OS gem install path handling Oct 14, 2026
@girachawda
girachawda requested a review from OughtPuts October 14, 2026 17:25
@girachawda
girachawda marked this pull request as ready for review October 14, 2026 17:25
@OughtPuts
OughtPuts merged commit 24566b6 into main Oct 15, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants