Auto-fix: spec failure in yaml-examples/showcase/12-while-loop.test.yaml - #19
Open
feng-shiplight wants to merge 1 commit into
Open
Conversation
…erification: verified) Commit b2ad439 raised the test-level `timeout` to 600000 but left the WHILE step's `timeout_ms: 300000`, so the loop still fails at 300s before scrolling the long 'Cat' article to its footer. Raise the WHILE `timeout_ms` from 300000 to 600000 to match the intended 10-minute budget. Opened automatically by CI Failure Triage; verification result recorded in the PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale inner
timeout_msin showcase while-loop testWhat failed
Test:
showcase/12-while-loop.test.yaml(while-loop-ai-condition, cloud case 419).The WHILE step that scrolls the "Cat" Wikipedia article until the footer is
visible aborted with:
At the point of timeout the loop had only scrolled down to the references
section of the article — it had not yet reached the footer, so the AI condition
"The page footer is not visible" was still true and the loop kept iterating
until it hit its own inner cap.
Root cause
Commit
b2ad439("Increase while loop test timeout to 10m") raised thetest-level budget:
…but left the WHILE step's own inner cap at the previous 5-minute value:
The inner
timeout_msgoverns the loop independently of the test-leveltimeout, so the loop still terminated at 300s regardless of the raisedtest budget.
The application behaves correctly. The "Cat" article is simply long enough that
scrolling to its footer takes more than 5 minutes of
scrolliterations; within300s the loop reached the references section, which is expected progress, not a
regression. Nothing in Wikipedia's rendering or the scroll behavior changed —
only the test's inner cap was left inconsistent with the intended 10-minute
budget. This is therefore a test-only fix.
The change
Raised the WHILE step's inner cap to match the intended budget:
This is the minimal edit that realizes the intent of commit
b2ad439(a10-minute budget for the loop). It changes a single value and touches no other
step, locator, or assertion.
Verification (recorded, not a merge gate): ✅ Verified — re-ran
yaml-examples/showcase/12-while-loop.test.yamltwice, both passed.Diff
Failing run: https://github.com/ShiplightAI/examples/actions/runs/33113350201