Skip to content

Auto-fix: spec failure in yaml-examples/showcase/12-while-loop.test.yaml - #19

Open
feng-shiplight wants to merge 1 commit into
mainfrom
triage-autofix/yaml-examples-showcase-12-while-loop-test-yaml-519c4eb9df73
Open

Auto-fix: spec failure in yaml-examples/showcase/12-while-loop.test.yaml#19
feng-shiplight wants to merge 1 commit into
mainfrom
triage-autofix/yaml-examples-showcase-12-while-loop-test-yaml-519c4eb9df73

Conversation

@feng-shiplight

Copy link
Copy Markdown
Contributor

Fix stale inner timeout_ms in showcase while-loop test

What failed

Test: showcase/12-while-loop.test.yaml (while-loop-ai-condition, cloud case 419).

The WHILE step that scrolls the "Cat" Wikipedia article until the footer is
visible aborted with:

While loop exceeded timeout of 300s

At the point of timeout the loop had only scrolled down to the references
section of the article — it had not yet reached the footer, so the AI condition
"The page footer is not visible" was still true and the loop kept iterating
until it hit its own inner cap.

Root cause

Commit b2ad439 ("Increase while loop test timeout to 10m") raised the
test-level budget:

timeout: 600000   # 10 min

…but left the WHILE step's own inner cap at the previous 5-minute value:

- WHILE: The page footer is not visible
  timeout_ms: 300000   # still 5 min — stale

The inner timeout_ms governs the loop independently of the test-level
timeout, so the loop still terminated at 300s regardless of the raised
test budget.

The application behaves correctly. The "Cat" article is simply long enough that
scrolling to its footer takes more than 5 minutes of scroll iterations; within
300s the loop reached the references section, which is expected progress, not a
regression. Nothing in Wikipedia's rendering or the scroll behavior changed —
only the test's inner cap was left inconsistent with the intended 10-minute
budget. This is therefore a test-only fix.

The change

Raised the WHILE step's inner cap to match the intended budget:

- WHILE: The page footer is not visible
  timeout_ms: 600000

This is the minimal edit that realizes the intent of commit b2ad439 (a
10-minute budget for the loop). It changes a single value and touches no other
step, locator, or assertion.


Verification (recorded, not a merge gate):Verified — re-ran yaml-examples/showcase/12-while-loop.test.yaml twice, both passed.

Diff
diff --git a/yaml-examples/showcase/12-while-loop.test.yaml b/yaml-examples/showcase/12-while-loop.test.yaml
index 0f41784..3c3fbb8 100644
--- a/yaml-examples/showcase/12-while-loop.test.yaml
+++ b/yaml-examples/showcase/12-while-loop.test.yaml
@@ -29,7 +29,7 @@ statements:
 
   # Scroll until the footer is visible
   - WHILE: The page footer is not visible
-    timeout_ms: 300000
+    timeout_ms: 600000
     DO:
       - intent: Scroll down 5 pages
         action: scroll

Failing run: https://github.com/ShiplightAI/examples/actions/runs/33113350201

Auto-generated by CI Failure Triage. Human review required — do not auto-merge. Decide based on the verification status above.

…erification: verified)

Commit b2ad439 raised the test-level `timeout` to 600000 but left the WHILE step's `timeout_ms: 300000`, so the loop still fails at 300s before scrolling the long 'Cat' article to its footer. Raise the WHILE `timeout_ms` from 300000 to 600000 to match the intended 10-minute budget.

Opened automatically by CI Failure Triage; verification result recorded in the PR.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant