Repository navigation
Fix immediate language refresh and share the language picker - #775
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing language could leave titles, settings rows, and bottom navigation in the previous language until scrolling or switching tabs. Make shared localization reads observable by Compose so translated content refreshes immediately while retaining screen state.
Use one common language picker and flag renderer on Android and iOS, share the six existing flag assets, and sort languages alphabetically by their native display names. Remove the unused root language forwarding and platform flag-resource API.
Validation: Android full dev build, iOS simulator app build, Kotlin lint, presentation architecture checks, and Android Studio formatting verification passed. Verified picker flags, alphabetical order, selected-language highlights, and immediate language changes through both application UIs. No automated tests added.
Checklist
Tested On