Skip to content

Fix immediate language refresh and share the language picker - #775

Merged
ShiftHackZ merged 1 commit into
developfrom
fix/immediate-language-refresh
Nov 19, 2026
Merged

ShiftHackZ merged 1 commit into
developfrom
fix/immediate-language-refresh

Conversation

@ShiftHackZ

Copy link
Copy Markdown
Owner

Description

Changing language could leave titles, settings rows, and bottom navigation in the previous language until scrolling or switching tabs. Make shared localization reads observable by Compose so translated content refreshes immediately while retaining screen state.

Use one common language picker and flag renderer on Android and iOS, share the six existing flag assets, and sort languages alphabetically by their native display names. Remove the unused root language forwarding and platform flag-resource API.

Validation: Android full dev build, iOS simulator app build, Kotlin lint, presentation architecture checks, and Android Studio formatting verification passed. Verified picker flags, alphabetical order, selected-language highlights, and immediate language changes through both application UIs. No automated tests added.

Checklist

  • I have ensured this PR does not contain any breaking changes for existing functionality
  • I have added automated tests that cover the new behavior and removed obsolete tests and code
  • I have added documentation for any new public APIs and update existing documentation for any changes to public APIs

Tested On

  • Android: Emulator
  • Android: Real device
  • iOS: Simulator
  • iOS: Real iPhone device

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tion/components/modal/language/LanguageFlagIcon.kt 0.00% 13 Missing ⚠️
...n/components/modal/language/LanguageBottomSheet.kt 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ShiftHackZ
ShiftHackZ merged commit 73c0afb into develop Nov 19, 2026
10 checks passed
@ShiftHackZ
ShiftHackZ deleted the fix/immediate-language-refresh branch November 19, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant